WordPress.org

Make WordPress Themes

Change History (4)

#1 @sixhours
6 years ago

  • Owner set to sixhours
  • Status changed from new to accepted

#2 @sixhours
6 years ago

All issues from the previous review are fixed (thank you!) with the exception of this one:

There's a navigation menu area defined in the header (Header Menu) but applying a custom menu there doesn't work (always defaults to the page list.)

I still can't apply a custom menu to the Header Menu area. It defaults to the page list. I think lines 50 - 52 in header.php are the problem:

if (function_exists('dynamic_sidebar') || dynamic_sidebar('Main')) { 
	wp_nav_menu();
} 

I'm not sure why the dynamic_sidebar is being used here, but changing the above to this worked for me FWIW:

wp_nav_menu( array( 'theme_location' => 'header-menu' ) );

Once that's fixed, the theme is Approved. Same as before, just comment with a link to the new trac ticket. :)

#3 @themesweet
6 years ago

Wonderful! Thanks so much for your help and pointing out the header issue. I really appreciate it. I've updated the theme and here's the link: http://themes.trac.wordpress.org/ticket/6330

Thanks again for everything!

#4 @sixhours
6 years ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from accepted to closed
Note: See TracTickets for help on using tickets.