Make WordPress Themes

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#6343 closed theme (not-approved)

THEME: sienna - 1.1.0

Reported by: john_wdl Owned by: jr.duboc
Priority: Keywords: theme-sienna
Cc: john@…

Change History (7)

#1 @cais
6 years ago

  • Owner set to jr.duboc
  • Status changed from new to assigned

#2 @jr.duboc
6 years ago

Here is my final review:


Templates tags and hooks

  • get_previous_posts_link() is used instead of previous_posts_link(), (same thing for "next" links"), but that's probably OK because the functionnalities are there. Any experienced reviewer who would be to able to confirm that ?
  • On line 15 of search.php, I found that the title levels are wrong: <h2><?php printf( ( 'Search Results for: %s', 'sienna_wdl' ), '<span>' . get_search_query() . '</span>' ); ?></h1>
  • get_search_form() → not here, but that’s probably OK because I didn’t find the corresponding template file (searchform.php).

Including Stylesheets and Scripts

  • Styles are included using bloginfo('stylesheet_url'), which I think is not appropriate.
  • bloginfo('pingback_url') is used for the pingback, but I dont’ think that’s a problem.


The theme includes required files (index, comments, screenshots), and all recommended ones.

That’s all I’ve found, the main problem I have is with the “Featured Post” section, but that is not strictly a them guideline violation. Rather, it’s something that is easy to fix and that would make using the theme easier :)

I’d recommend fixing the few problems I noticed, and you should be approved :)

Good work, it’s a nice theme :)

#3 @cais
6 years ago

Resolved as "not-approved"; please address the issues as noted and re-submit. They appear to be relatively quick fix items and as such copy the original reviewer for follow-up in this case.

#4 @cais
6 years ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

#5 @john_wdl
6 years ago


The featured post was like you suggested in 1.0.0, i changed it in 1.1.0 as i felt the design is a bit ugly if its not there.

Its a design decision not a required fix, so can you approve it?

I will upload a new version with the h1 fix.


#7 @john_wdl
6 years ago


here is the new ticket :

fixed the h1/h2 mismatch...

Note: See TracTickets for help on using tickets.