Make WordPress Themes

Opened 6 years ago

Closed 6 years ago

#6399 closed theme (not-approved)

THEME: sapphire - 1.2.0

Reported by: john_wdl Owned by: kwight
Priority: Keywords: theme-sapphire
Cc: john@…

Change History (2)

#1 @kwight
6 years ago

  • Owner set to kwight
  • Status changed from new to assigned

#2 @kwight
6 years ago

  • Resolution set to not-approved
  • Status changed from assigned to closed


Not approved, due to above requirements.

Hi John,

The page from Smashing says "The set may not be resold, sub-licensed, rented, transferred or otherwise made available for use." Even though they don't mention what license it's released under, it will not be GPL-compatible. Everything else under images also falls under this requirement; if they're all yours, just explicitly say so in readme.txt also.

Sorry, my note about jQuery should have said "only" Core-bundled jQuery - an old 1.4.2 version (in includes/js) is also getting loaded by the theme.

The errors are:

  • Notice: Undefined variable: mydata in /Users/kwight/Sites/review/wp-content/themes/sapphire/includes/fn-custom.php on line 73
  • Warning: Cannot modify header information - headers already sent by (output started at /Users/kwight/Sites/review/wp-content/themes/sapphire/includes/fn-custom.php:73) in /Users/kwight/Sites/review/wp-includes/pluggable.php on line 866

A variable that doesn't seem to do anything is being returned; commenting it out gets rid of the errors. Unless it's supposed to be there for something, you can just remove it.

Are you developing with WP_DEBUG true in wp-config.php? If so, the errors should come up.


Note: See TracTickets for help on using tickets.