WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

#6411 closed theme (closed-newer-version-uploaded)

THEME: SnC Mono - 0.11

Reported by: tiper Owned by: sixhours
Priority: Keywords: theme-snc-mono
Cc: tiper.loc@…

Attachments (6)

commentnav2.jpg (9.1 KB) - added by sixhours 2 years ago.
wideimage.jpg (112.9 KB) - added by sixhours 2 years ago.
menu.jpg (57.0 KB) - added by sixhours 2 years ago.
search.jpg (25.7 KB) - added by sixhours 2 years ago.
commentnav.jpg (11.7 KB) - added by sixhours 2 years ago.
horizontalscroll.jpg (87.4 KB) - added by sixhours 2 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 sixhours2 years ago

  • Owner set to sixhours
  • Status changed from new to accepted

sixhours2 years ago

sixhours2 years ago

sixhours2 years ago

sixhours2 years ago

sixhours2 years ago

sixhours2 years ago

comment:2 sixhours2 years ago

Theme Check

No required items reported.


Code Review

Scripts and styles (with the exception of style.css) should be enqueued in functions.php, not linked directly in header.php

style.css should be linked in the header or enqueued in functions.php, not brought in using @import

$content_width should be set in functions.php, not header.php

Register sidebar should be part of a function hooked into widgets_init like so:

function snc_mono_sidebars() {

register_sidebar();

}
add_action( 'widgets_init', 'snc_mono_sidebars' );

Theme setup functions should be part of a function hooked into after_setup_theme like so:

function snc_mono_theme_setup() {

add_theme_support( 'post-thumbnails' );
Other add_theme_support functions

}
add_action( 'after_setup_theme', 'snc_mono_theme_setup' );

wp_footer() should come directly before the closing HTML body tag in footer.php

Functions that are more than one major WP release past should not be wrapped in function_exists conditionals (ie dynamic_sidebar in sidebar.php)


Theme Unit Tests

Layout scrolls horizontally (see attached screencap horizontalscroll.jpg)

Images: Wide image overflows the content area, see attached screencap wideimage.jpg)

The Custom Menu widget links are not appearing properly… they float up over the header and page links, see attached screencap menu.jpg

Search box disappears/floats under other sidebar widgets (see attached screencap search.jpg)

Calendar widget needs styling (see attached screencap search.jpg)

Comments have erroneous page links next to them (see attached screencap commentnav.jpg)

Paginated comments navigation runs into the divider (see attached screencap commentnav2.jpg)

Twitter and Facebook buttons should be "opt-in" and configurable via a Theme Options panel of some sort. Requiring users to edit the parent theme files is not acceptable, as future changes to the theme might overwrite a user's customizations. The same goes for adding a logo image to the header, changing default search text, and additional modifications to the background colors. If these are things you want users to be able to do, they should be included as theme options.

Recommendation: This is not required, but adding custom menu capabilities to the header would allow users to choose which navigation tabs appear there. Currently, someone with lots of main pages will have a cluttered header (again, see screencap menu.jpg)


I'm marking this Not Approved as there are many fixes needed. I'll keep this ticket open for the next two days; should you make the required changes during that time, please upload your theme again and comment here with a link to the new trac ticket and I'll be happy to re-review!

comment:3 tiper2 years ago

Hi, first of all I'd like to thanky you for the review and all your tips. Almost everything is corrected right now but there are few fixes needed to be made and I wish could make them in 2 days but I got other projects going on so I'm asking for 2 more days for this ticket to be open. If I'm going to start a new ticket then it's probably another month of silence.

Thanks for the understanding and again thanks for the review.

Regards,
Tiper.

comment:4 sixhours2 years ago

That's reasonable--thanks for letting me know! I'll leave the ticket open for 2 more days.

comment:5 tiper2 years ago

http://themes.trac.wordpress.org/ticket/6750 - here is a ticket. I still have one problem though - I can't seem to find that "newer comments" thing. I'm using theme test unit from here - http://codex.wordpress.org/Theme_Unit_Test and it's not being shown anywhere. Maybe I'm missing some plugin or some option need to be turned on.

I would also be really greatful for shedding some light on custom admin screen if this is what it's called. I can't figure out how to add non-standard theme options to wordpress admin panel. What I'm looking for is the correct name of such a procedure so I can find accurate info about it.

Regards,
Tiper.

comment:6 sixhours2 years ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from accepted to closed

Hi Tiper,

Thanks! I'll re-review what you've got so far.

To see the older/newer comments links you should have paginated comments enabled in your Settings -> Discussion area, then look at the Comment Test post. You should see the comment navigation at the bottom of that page.

And for theme options, my recommendation is to check out another reliable, bare bones theme template like _s (https://github.com/Automattic/_s) and see how they code the Theme Options page and call the options.

Note: See TracTickets for help on using tickets.