WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#6545 closed theme (not-approved)

THEME: Redify - 1.0

Reported by: priyanshu.mittal Owned by: garinungkadol
Priority: Keywords: theme-redify
Cc: priyanshu.mittal@…

Description

Redify - 1.0

A Free red colored Business Blog theme that supports Primary menu's , Primary and Secondary sidebars,Four widgets area at the footer region,Custom Post Types and nice option panel . It has a perfect design that's great for any Business/Firms Blogs who wants a new look for their site.Two page templates are provided one for the portfolio and second for the contact us page. Nice bit of optional panel is made for the theme setting and customization.Redify supports featured post slider based on the concept of custom post types whose settings are also given in the option panel.The featured post slider can easily be converted to the image slider by just disabling an option in the home page slider setting's tab.

Theme URL - http://redify.webriti.com
Author URL - http://www.webriti.com

SVN - http://themes.svn.wordpress.org/redify/1.0
ZIP - http://wordpress.org/extend/themes/download/redify.1.0.zip?nostats=1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-redify

https://themes.svn.wordpress.org/redify/1.0/screenshot.png

Change History (15)

comment:1 garinungkadol2 years ago

  • Owner set to garinungkadol
  • Status changed from new to assigned

comment:2 garinungkadol2 years ago

  • Keywords synchold added
  • Resolution set to not-approved
  • Status changed from assigned to closed

THEME REVIEW RESULTS

This is a partial review. In addition to the items noted below, make sure that your theme meets the requirements outlined in the Theme Review Guidelines before re-submitting.

If you have any questions, feel free to ask them here.

RECOMMENDATION: NOT-APPROVED

THEME INFORMATION

  • Author URI: There is not enough information to indicate if this is a personal or a project development site. It would help a lot if you could provide an "About" page.
  • Screenshot: The screenshot must fall within the prescribed size: 300x225px to 320x240px
  • Licensing: Note the image licensing in the readme.txt.

DEBUGGER ERRORS

On Widgets page after theme is first activated
-- Undefined variable: args in C:\xampp\htdocs\wordpress\themereview\wp-content\themes\redify\functions.php on line <b>274</b>

On Theme Settings Page
On C:\xampp\htdocs\wordpress\themereview\wp-content\themes\redify\option_pannel\general_settings.php
-- Debug: Undefined index: action on line 22
-- Debug: Undefined index: action on line 27
-- Debug: Undefined index: general_settings on line 33
On C:\xampp\htdocs\wordpress\themereview\wp-content\themes\redify\option_pannel\typography.php
-- Debug: Undefined index: typography on line 20
-- Debug: Undefined index: typography on line 847
On C:\xampp\htdocs\wordpress\themereview\wp-content\themes\redify\option_pannel\homepage_slider.php
-- Debug: Undefined index: homepage_sliders on line 18
-- Debug: Undefined variable: checkbox_homepage_slider on line 70
-- Debug: Undefined variable: animation_speed on lines 145 - 163
-- Debug: Undefined variable: auto_slide_interval on line 182 - 189
-- Debug: Undefined index: homepage_sliders on line 274
On C:\xampp\htdocs\wordpress\themereview\wp-content\themes\redify\option_pannel\footer_customization.php
-- Debug: Undefined index: footer_customization on line 17
-- Debug: Undefined index: footer_customization on line 201


VISUAL ISSUES / FUNCTIONALITY / BROWSER CHECKS

  • REQUIRED: You should not be including the theme's name as the logo. It should either be a generic place-holder or the site's name.
  • REQUIRED: Check the display of multi-level menus when the fallback menu is displayed.
  • REQUIRED: Check your implementation of Navigation Menus. The selected menu does not display on the site.
  • REQUIRED: You shouldn't be including styles within HTML tags e.g. <div style="float:right;width:660px;padding:8px;">. You should be placing these in stylesheet files.

CODE QUALITY

Theme Settings

  • REQUIRED: You must prefix all options, custom functions, custom variables and custom constants with the theme-slug or an appropriate variant.
  • REQUIRED: You must the use edit_theme_options capability for add_theme_page() instead of manage_options.
  • REQUIRED: You must save options in a single array. You are saving multiple options.
  • REQUIRED: For checkboxes and select options, you must use the checked() and selected() functions for outputting checked="checked" and selected="selected" respectively
  • REQUIRED: While using the Settings API to handle your settings pages is optional, if you do not use it you must make sure that your custom settings pages includes the following:
    • Page-specific nonce declaration
    • Checking of nonces upon submission of form data (before updating to the database)
    • Sanitization/validation of data before updating options. See Data Security notes below.

Data Security

  • REQUIRED: You must validate and sanitize all untrusted data before entering into the database, and to escape all untrusted data before being displayed in forms.
  • REQUIRED: Use esc_attr() for text inputs and esc_html() or esc_textarea() for text areas
  • REQUIRED: Custom forms i.e. the contact form must include nonces

Translation Support. See Translating WordPress
While support for other languages is optional, if included you are required to:

  • Use the theme-slug, "redify" as the textdomain
  • Make sure that all text is translatable by using the functions, __e() or __().

Inclusion of styles and scripts

  • REQUIRED: Styles that are needed in specific circumstances can either be enqueued conditionally or placed in a function that hooks into wp_head
  • REQUIRED: You should not be bundling jQuery with your theme package. You must make use of the jQuery version bundled with WordPress.
  • REQUIRED: Only the theme's style.css may be hard-coded in header.php. All other styles must be placed in a function that hooks into wp_enqueue_scripts or for hard-coded styles, into wp_head.
  • REQUIRED: Enqueuing of scripts should not be done in header.php. Place the comment-reply script in a function that hooks into wp_enqueue_script.

Other Issues

  • REQUIRED: Check the placement of the closing brace } for function the_theme_setup().
  • REQUIRED: wp_link_pages( $args ) belongs in template files not in functions.php
  • REQUIRED: You should use the fallback callback argument when registering navigation menus.

OTHER NOTES

  • REQUIRED: Change all references to Twenty Eleven in your theme in the in-line documentation.
  • REQUIRED: Check your readme.txt file. It doesn't contain any information about your theme. You must document the use of special templates and custom post types here.

comment:3 follow-up: priyanshu.mittal2 years ago

first of all thansk for reviewing my site, do spare me, i am new to this, will follow your suggestions very carefully, will get back to you as soon as possible

comment:4 in reply to: ↑ 3 garinungkadol2 years ago

Replying to priyanshu.mittal:

first of all thansk for reviewing my site, do spare me, i am new to this, will follow your suggestions very carefully, will get back to you as soon as possible


We're here to help so if you have any questions, you can comment here and I'll do my best to help you.

comment:5 garinungkadol2 years ago

An additional note: You should not be setting the option for a blog's name. Your theme changes the site title to "Redify".

comment:6 follow-up: priyanshu.mittal2 years ago

i dint understand some of the issues highlighted by you also please tell me what tool you have used for this review process the reason y i am asking this bcs i had used this worpdress review tool and dint find that much issues......

comment:7 in reply to: ↑ 6 garinungkadol2 years ago

Replying to priyanshu.mittal:

i dint understand some of the issues highlighted by you also please tell me what tool you have used for this review process the reason y i am asking this bcs i had used this worpdress review tool and dint find that much issues......


Which issues are you having problems will? I'll try to explain them better.

As for the tools I use:

comment:8 follow-up: priyanshu.mittal2 years ago

you made this point "REQUIRED: You should not be including the theme's name as the logo. It should either be a generic place-holder or the site's name."

instead i have given a place for the site title. you can set whatever value you will like to display in this place just by settings a site title from the general settings options..but as suggested by you i can change this place so as to display the site name somewhat like xyz.com....
Secondly, "REQUIRED: You should not be bundling jQuery with your theme package. You must make use of the jQuery version bundled with WordPress?." you mean to say abt the jquery libray bundled with the wordpress or the library bundeled with the slider script.....?

comment:9 in reply to: ↑ 8 garinungkadol2 years ago

Replying to priyanshu.mittal:

you made this point "REQUIRED: You should not be including the theme's name as the logo. It should either be a generic place-holder or the site's name."

instead i have given a place for the site title. you can set whatever value you will like to display in this place just by settings a site title from the general settings options..but as suggested by you i can change this place so as to display the site name somewhat like xyz.com....


During my testing, your theme updated the option 'blogname' to 'Redify'. You should not be changing these types of options without user permission. See functions.php

Line 415 update_option('blogname', 'Redify');
Line 416 update_option('posts_per_page','6');
Line 417 update_option('portfolio_post','8'); 
  • You should not be updating the 'posts_per_page' option. Once again, you need explicit permission from the user to change this. If you want your own number of posts per page, make use of the pre_get_posts action
  • I don't know whether 'portfolio_post' is a WordPress option. If it isn't then it needs to belong to the theme option.


Secondly, "REQUIRED: You should not be bundling jQuery with your theme package. You must make use of the jQuery version bundled with WordPress?." you mean to say abt the jquery libray bundled with the wordpress or the library bundeled with the slider script.....?


You have two different versions of jQuery bundled with your theme: http://themes.svn.wordpress.org/redify/1.0/js/

As per the Theme Review guidelines:

Themes are required to use core-bundled scripts, if using such scripts

The reason behind this is that other core-bundled scripts and plugins may be referencing jQuery and if you override the existing version for your own, it may cause plugin or core breakage.
See this http://make.wordpress.org/themes/2011/11/10/wordpress-3-3-proposed-guidelines-revisions/#comment-14660 on theme review site.

http://make.wordpress.org/themes/2011/11/10/wordpress-3-3-proposed-guidelines-revisions/#comment-14661

comment:10 garinungkadol2 years ago

  • Keywords synchold removed

comment:11 follow-up: priyanshu.mittal2 years ago

hey i have made all the changes as listed by ....now where should i share the updated release of the theme

comment:12 in reply to: ↑ 11 garinungkadol2 years ago

Replying to priyanshu.mittal:

hey i have made all the changes as listed by ....now where should i share the updated release of the theme


Upload your revised theme so that a new trac ticket can be created

comment:13 follow-up: priyanshu.mittal2 years ago

hi

i tried to upload the revised theme this gave me the error

"Duplicate theme and author URLs. A theme URL is a page/site the provides details about this specific theme. An author URL is a page/site that provides information about the author of the theme. You aren't required to provide both, so pick the one that best applies to your URL."

comment:14 in reply to: ↑ 13 garinungkadol2 years ago

Replying to priyanshu.mittal:

hi

i tried to upload the revised theme this gave me the error

"Duplicate theme and author URLs. A theme URL is a page/site the provides details about this specific theme. An author URL is a page/site that provides information about the author of the theme. You aren't required to provide both, so pick the one that best applies to your URL."


Check your style.css. You gave the same URL for the Theme URI and Author URI

comment:15 priyanshu.mittal2 years ago

hey i have relased the theme and my ticket id is 7070

Note: See TracTickets for help on using tickets.