Make WordPress Themes

Change History (6)

#1 @garinungkadol
4 years ago

  • Owner set to garinungkadol
  • Status changed from new to assigned

#2 @garinungkadol
4 years ago

  • Keywords synchold added
  • Resolution set to not-approved
  • Status changed from assigned to closed


The pending issues below are minor ones. Once you have made the required revisions we will be able to approve your theme.

Pending Issues

  • NOT-FIXED: Floated elements must be properly cleared.
  • PARTIALLY-FIXED: Registered sidebars are hooked into widgets_init though this is not an appropriate hook for knrdecorous_register_thememenu can be hooked into init while knrdecorous_register_themecapabilities is hooked into after_theme_setup.
  • REQUIRED: Screenshot must fall within the prescribed dimension range of 300x225px to 320x240px.

Fixed Issues

  • FIXED: References to twenty eleven have been removed.
  • FIXED: Commented out code in header.php has been removed.
  • FIXED: Using get_stylesheet_uri over bloginfo('stylesheet_url').
  • FIXED: Using echo home_url() instead of bloginfo(url) in header.php
  • FIXED: Added 'Theme URI' to style.css header
  • FIXED: Wide images no longer exceed the content area.
  • FIXED: Added padding between columns to separate text.
  • FIXED: Each post in a column has the same post height.
  • FIXED: Caption in the "Post Format Test: Image (Linked)" post is no longer cut-off
  • FIXED: Posts with no Post Title displays the link to the single post page view.
  • FIXED: Sub-menu links are visible when hovering over parent link.
  • FIXED: Pages with comments disabled no longer shows "Comments are closed".
  • FIXED: 404 (Page Not Found) displays a message instead of blank content area. I would recommend including get_search_form() to display the search form.

#3 @k_nitin_r
4 years ago


Thank you for your feedback.

Regarding the hook being used in functions.php, please take a look at the following:

-=[ Scenario 1 ('init' hook) ]=-

This is the line in functions.php:
add_action('init', 'knrdecorous_register_themecapabilities');

WordPress calls the function 'knrdecorous_register_themecapabilities', which contains the statement 'add_theme_support('automatic-feed-links');' and outputs the following in the markup of the site (right-click on the page, select "View Page Source", and look at the HEAD tag, a few lines below the TITLE tag):
<link rel="alternate" type="application/rss+xml" title="WP Test Bench &raquo; Feed" href="http://localhost:801/wordpress/?feed=rss2" />
<link rel="alternate" type="application/rss+xml" title="WP Test Bench &raquo; Comments Feed" href="http://localhost:801/wordpress/?feed=comments-rss2" />

-=[ Scenario 2 ('after_theme_setup' hook) ]=-

This is the line in functions.php
add_action('after_theme_setup', 'knrdecorous_register_themecapabilities');

When using the 'after_theme_setup' hook, the output is not produced.

#4 @k_nitin_r
4 years ago

For the other issues, I have created a new screenshot image that is of "320x240px" dimensions and I cleared the float that remains after the posts (in version 0.4, only the float used within the post Eg. the image alignLeft was cleared).

I'll post the new version shortly.

#5 @k_nitin_r
4 years ago

I have uploaded a new version of the theme at http://themes.trac.wordpress.org/ticket/6609

#6 @garinungkadol
4 years ago

  • Keywords synchold removed
Note: See TracTickets for help on using tickets.