Make WordPress Themes

Opened 8 years ago

Closed 7 years ago

#67926 closed theme (not-approved)

THEME: Informative Blogs – 1.0.0

Reported by: shashank3105 Owned by: timph
Priority: new theme Keywords: theme-informative-blogs
Cc: shashank3105@…

Description

Informative Blogs - 1.0.0

Description

Theme URL - ​https://github.com/shashank3105/
Author URL - ​https://profiles.wordpress.org/shashank3105/

Trac Browser - https://themes.trac.wordpress.org/browser/informative-blogs/1.0.0

SVN - ​https://themes.svn.wordpress.org/informative-blogs/1.0.0
ZIP - ​https://wordpress.org/themes/download/informative-blogs.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#67926 THEME: Informative Blogs – 1.0.0 closed not-approved timph

(this ticket)

#69395 THEME: Informative Blogs – 1.0.4 closed closed-newer-version-uploaded kabirajlamichhane
#71664 THEME: Informative Blogs 1.0.5 – 1.0.5 closed not-approved rabmalin
#71673 THEME: Informative Blogs – 1.0.6 closed live kafleg


https://themes.svn.wordpress.org/informative-blogs/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Change History (4)

#1 @timph
7 years ago

Hey @shashank3105,

In checking out your theme there's a few things left before it will be good to go:

  1. Author URI should be your own website, not your wordpress.org profile page in your style.css:

https://themes.trac.wordpress.org/browser/informative-blogs/1.0.0/style.css#L5

  1. Scripts/styles should be enqueued using core methods:

https://themes.trac.wordpress.org/browser/informative-blogs/1.0.0/style.css#L29

  1. Description should be a description about your theme:

https://themes.trac.wordpress.org/browser/informative-blogs/1.0.0/style.css#L6

  1. License URI should be a resource that describes the theme's license:

https://themes.trac.wordpress.org/browser/informative-blogs/1.0.0/style.css#L9

  1. Author should be your wp.org user, @shashank3105 :

https://themes.trac.wordpress.org/browser/informative-blogs/1.0.0/style.css#L4

  1. Theme URI should be a URI relevant to your theme, not your github profile:

https://themes.trac.wordpress.org/browser/informative-blogs/1.0.0/style.css#L3

  1. Themes are required to support the latest version of WordPress. The Tested Up To field should indicate that:

https://themes.trac.wordpress.org/browser/informative-blogs/1.0.0/readme.txt#L7

  1. readme.txt is missing attribution to 3rd party resources used in the theme. All resources should be documented:

https://themes.trac.wordpress.org/browser/informative-blogs/1.0.0/readme.txt

This includes any image used in your theme ( also any image used in your theme's screenshot ), bootstrap, and _s theme.

  1. Themes should not include commented out code:

https://themes.trac.wordpress.org/browser/informative-blogs/1.0.0/rtl.css#L12

This file should be removed if there's not going to be any included styles for rtl support.

  1. bootstrap.js is being enqueued improperly with output of use wp_enqueue_script instead of wp_enqueue_style:

<link rel='stylesheet' id='informativeblogs-bootstrapJs-css' href='https://demo2.cloudwp.dev/trial-5y805ytz/wp-content/themes/informative-blogs/js/bootstrap.min.js?ver=20151215' type='text/css' media='1'/>

  1. Theme adds support for custom header images, and the customizer control to add a custom header image does not work. You should remove this feature or ensure that the header image gets applied to the header properly.
  1. Tagline is not output anywhere on the site, so the control in the customizer does not work as expected. You should add output for the tagline, this is typically added to the branding section with the site title in bootstrap based themes if that helps give you some ideas.
  1. The languages/informativeblogs.pot file can be included, but it should match the theme properly. Theres strings that don't exist, I'd recommend you delete this if you're not going to run a build/maintain the languages yourself. In doing so you can take advantage of wp.org handling this.
  1. The textdomain for your theme should be based off the theme's slug informative-blogs, but you used informativeblogs - so this needs to be replaced.

​https://make.wordpress.org/themes/handbook/review/required/explanations-and-examples/#language

You can find the specific line numbers if you run Theme Sniffer plugin to spot the issues:

FILE: /home/tria506z6zyz/public_html/wp-content/themes/informative-blogs/404.php
--------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------------------------------------
 18 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
 22 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
 31 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
 47 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
--------------------------------------------------------------------------------------------------------------


FILE: /home/tria506z6zyz/public_html/wp-content/themes/informative-blogs/comments.php
--------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------
 35 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
 41 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
 66 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
--------------------------------------------------------------------------------------------------------------


FILE: /home/tria506z6zyz/public_html/wp-content/themes/informative-blogs/footer.php
--------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------
 20 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
 23 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
 29 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
--------------------------------------------------------------------------------------------------------------


FILE: /home/tria506z6zyz/public_html/wp-content/themes/informative-blogs/functions.php
--------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------
  47 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
     |       | (WordPress.WP.I18n.TextDomainMismatch)
 108 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
     |       | (WordPress.WP.I18n.TextDomainMismatch)
 110 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
     |       | (WordPress.WP.I18n.TextDomainMismatch)
--------------------------------------------------------------------------------------------------------------


FILE: /home/tria506z6zyz/public_html/wp-content/themes/informative-blogs/header.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 25 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
--------------------------------------------------------------------------------------------------------------


FILE: /home/tria506z6zyz/public_html/wp-content/themes/informative-blogs/inc/template-tags.php
--------------------------------------------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 8 LINES
--------------------------------------------------------------------------------------------------------------
 29 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
 45 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
 62 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
 65 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
 69 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
 72 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
 82 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
 99 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
--------------------------------------------------------------------------------------------------------------


FILE: /home/tria506z6zyz/public_html/wp-content/themes/informative-blogs/search.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 22 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
--------------------------------------------------------------------------------------------------------------


FILE: /home/tria506z6zyz/public_html/wp-content/themes/informative-blogs/template-parts/content-none.php
--------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------------------------------------
 14 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
 24 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
 37 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
 44 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
--------------------------------------------------------------------------------------------------------------


FILE: /home/tria506z6zyz/public_html/wp-content/themes/informative-blogs/template-parts/content-page.php
--------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------
 24 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
 37 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
--------------------------------------------------------------------------------------------------------------


FILE: /home/tria506z6zyz/public_html/wp-content/themes/informative-blogs/template-parts/content.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 47 | ERROR | Mismatched text domain. Expected 'informative-blogs' but got 'informativeblogs'.
    |       | (WordPress.WP.I18n.TextDomainMismatch)
--------------------------------------------------------------------------------------------------------------

These aren't required, but it would be good to look at:

  1. I'd recommend to change the style for the fixed header so it accounts for a logged in user, and the wpadminbar doesn't cover it. There's a body class available for this purpose.
  1. Are you sure the mobile menu is working the way you want? When I click on it, it's not a very great experience with the toggling. This is probably because of the bootstrap.js enqueue issue that is required above though.
  1. Check the Theme Unit Test data to cover scenarios. The page with no content, your footer is in the middle of the page. This impacts pages/posts with short/little content.
Last edited 7 years ago by timph (previous) (diff)

#2 @timph
7 years ago

  • Owner set to timph
  • Status new → reviewing

#3 @timph
7 years ago

@shashank3105 As this theme had 3 or more errors, and I haven't heard back from you in a couple of days, I'll be closing this ticket. Don't get discouraged though, we don't disallow authors from submitting or resubmitting their theme, and we understand that sometimes changes can take some time! I look forward to your next revision, and encourage you to double check your theme against the theme review guidelines before resubmitting: ​https://make.wordpress.org/themes/handbook/review/required/

Also, be sure to test your theme with these plugis:
​https://wordpress.org/plugins/theme-check/
​https://wordpress.org/plugins/theme-sniffer/ [Errors need to be fixed and Warnings are things that need to be checked manually.]

#4 @timph
7 years ago

  • Resolution → not-approved
  • Status reviewing → closed
Note: See TracTickets for help on using tickets.