WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#6833 closed theme (live)

THEME: Sundance - 1.0

Reported by: automattic Owned by: Mamaduka
Priority: Keywords: theme-sundance
Cc: themes@…

Description

Sundance - 1.0

A free video theme brought to you by the folks at Automattic. Despite its minimalist design, Sundance was crafted with clean, elegant typography and close attention to detail. The home page offers a featured video carousel. It supports the video post format, widgets, custom background, custom header, custom menus, and a custom link feature for your social media pages.

Theme URL - http://theme.wordpress.com/themes/sundance/
Author URL - http://automattic.com/

SVN - http://themes.svn.wordpress.org/sundance/1.0
ZIP - http://wordpress.org/extend/themes/download/sundance.1.0.zip?nostats=1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-sundance

https://themes.svn.wordpress.org/sundance/1.0/screenshot.png

Change History (6)

comment:1 Mamaduka2 years ago

  • Owner set to Mamaduka
  • Status changed from new to assigned

comment:2 Mamaduka2 years ago

Theme Check

No errors where found.

Theme Unit Test

Meets all requirements.

Proposed resolution: approved

comment:3 chipbennett2 years ago

Theme does not appear to use a unique namespace/prefix in all required elements, such as custom action hooks.

comment:4 chipbennett2 years ago

Just because @Mamaduka asked for a secondary review:

  • Not required, but recommended: it would be awesome if this Theme filtered wp_title() via the wp_title filter, rather than hard-code the HTML <title> tag output in the template.
  • Perhaps overkill, but it would also be best-practice to escape the output of bloginfo( 'description' ); in the template.
  • Required indicate copyright/license for all bundled resources, including images/icons

Those were my only observations from a very brief spot-check. As the reviewer, it is your prerogative whether you want to allow a minor required issue to be resolved in the next revision, or to ask for a revision to be submitted prior to approval.

comment:5 Mamaduka2 years ago

  • Resolution set to approved
  • Status changed from assigned to closed

Thanks Chip.

Just noticed that both your recommendations isn't common practice in Theme development.

I'll approve this theme, but minor required issue should be resolved in next revision.

comment:6 chipbennett2 years ago

You're right: they're not (yet) common practice. :)

Note: See TracTickets for help on using tickets.