Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

#6899 closed theme (not-approved)

THEME: Tiny - 1.2

Reported by: marcel_ Owned by: Mamaduka
Priority: Keywords: theme-tiny
Cc: webmaster@…


Tiny - 1.2

Great to have you here! Tiny for everyone interested in writing and maybe comics and stuff. It's not for everyone. It is for you. Thank you for using this Theme. I hope you have fun with it. If you got any problems with it, just send me an email and I provide a fix as soon as possible. It is completely optional, but if you like the Theme I would appreciate it if you keep the credit link at the bottom.

Theme URL - http://wordpress.org/extend/themes/tiny
Author URL - http://www.kunstaufkarten.de

SVN - http://themes.svn.wordpress.org/tiny/1.2
ZIP - http://wordpress.org/extend/themes/download/tiny.1.2.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/tiny/1.1&new_path=/tiny/1.2

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-tiny&order=id


Change History (2)

comment:1 Mamaduka2 years ago

  • Owner set to Mamaduka
  • Status changed from new to assigned

comment:2 Mamaduka2 years ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

Issues from previous ticket

  • Credit links - fixed
  • Correct theme URI - fixed
  • Sponsored link in theme description - fixed
  • Twenty Eleven references - fixed

You changed theme Twenty Eleven reference by simple find/replace action, themes are recommended to use slug (tiny) as texdomain and prefix for functions/variables, also this replacement affected not all textdomains and functions, that caused PHP error notice:

 Fatal error: Call to undefined function twentyeleven_posted_on() in C:\wamp\www\wptrt\wp-content\themes\tiny\content-aside.php on line 45

Themes must not provide any kind of PHP errors, also make sure to change textdomain to tiny everywhere.

Theme Options are implemented, but it doesn't work, it's just inherited from Twenty Eleven, if your theme doesn't require this functionality you can fully remove it, otherwise you should implement it properly. Same goes with custom headers, Twenty Eleven default headers are registered, but those images aren't bundled with theme, also can't find any template tag displaying theme header, so same rules goes here - if you're not using custom header functionality, then don't register it or remove related functions.

Themes are required to enqueue properly all stylesheets and scripts - http://codex.wordpress.org/Theme_Review#Including_Stylesheets_and_Scripts.

So you should enqueue google fonts like this.

function tiny_enqueue_googlefonts(){
    wp_enqueue_style( 'gudea-font', 'http://fonts.googleapis.com/css?family=Gudea:400,700' );
add_action( 'wp_enqueue_scripts', 'tiny_enqueue_googlefonts' );

Resolution not-approved, required issues must be fixed.

Note: See TracTickets for help on using tickets.