WordPress.org

Make WordPress Themes

Change History (6)

comment:1 kobenland2 years ago

  • Owner set to kobenland
  • Status changed from new to assigned

comment:2 kobenland2 years ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

THEME REVIEW RESULTS

  • Previous version of Theme NOT-APPROVED

Previous Issues from #6885

  • FIXED: Theme URI is not appropriate. It is both a "generic" URL (i.e. not specific to this Theme), and also is merely a demo of the Theme.
  • Still not fixed:
    • All Theme-defined functions must be custom-prefixed
    • Scripts and stylesheets must be enqueued rather than hard-coded in the HTML document head
    • Must use core-bundled version of jQuery. Version linked in document head is outdated
    • jQuery scripts must use no-conflict syntax
    • Navigation menus are required to support core custom navigation menu functionality
    • All public-facing text must be in English, with translation support provided for other languages, if needed
    • Translation support is only partially implemented


Review Summary

  • Diff review only
  • Theme has required issues (see above)
  • Ticket being resolved as NOT-APPROVED. Please address required issues in next Theme revision.


Please note: (copied in parts from SeizedPropaganda)

  • Theme will be held for approval until items listed as REQUIRED are addressed. Once these issues have been resolved, please re-submit your Theme using the uploader tool on wordpress.org, and a new Trac ticket will be generated.
  • Re-submitted Themes are given review priority over new Themes. Any review-based Theme revision that is submitted within two days of the previous review and linked to from the previous ticket will be accepted by the previous-ticket reviewer, and the review continues on the new ticket.
  • The Theme Review Team will no longer emphasize complete and thorough reviews, and will instead close tickets upon observation of any non-trivial issues.
  • Themes should be reviewed using define( 'WP_DEBUG', true ); in wp-config.php
  • Theme developer questions, comments, and feedback are welcome and encouraged. Please use one of the following methods:
    1. Leave a comment on this ticket
    2. Email the theme-reviewers email list
    3. Use the #wordpress-themes channel on irc.freenode.net

comment:3 bernabe.ber2 years ago

I do not understand this:
. All Theme-defined functions must be custom-prefixed
. Scripts and stylesheets must be enqueued rather than hard-coded in the HTML document head

Can you give me some example?.

comment:4 kobenland2 years ago

Themes are required to prefix all options, custom functions, custom variables, and custom constants with theme-slug (or appropriate variant).
Bad: admin_header_style()
Good: bere_elegant_admin_header_style()

Enqueue Scripts like so:

<?php
function bere_elegant_scripts() {
   // enqueue your script with location, dependencies and version
   wp_enqueue_script('custom_script',
       get_template_directory_uri() . '/js/custom_script.js',
       array('jquery'),
       '1.0' );
}
add_action( 'wp_enqueue_scripts', 'bere_elegant_scripts' );

See the Codex for reference.

comment:5 bernabe.ber2 years ago

I do not understand this:

. Navigation menus are required to support core custom navigation menu functionality
.All public-facing text must be in English, with translation support provided for other languages, if needed
. Translation support is only partially implemented

Can you give me some example?.

comment:6 kobenland2 years ago

Please consult the Codex first for questions on Theme Development and Theme Review Guidelines.

Note: See TracTickets for help on using tickets.