WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

#6952 closed theme (not-approved)

THEME: Dorp - 1.1

Reported by: Andre96 Owned by: Mamaduka
Priority: Keywords: theme-dorp
Cc: meyeringandre@…

Change History (2)

comment:1 Mamaduka2 years ago

  • Owner set to Mamaduka
  • Status changed from new to assigned

comment:2 Mamaduka2 years ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

From Previous Review

  • __MACOSX folder - not-fixed
  • Clearing flaots - fixed
  • Header styling - fixed
  • Video format test - fixed
  • PHP errors - not-fixed
  • deprecated function - fixed

__MACOSX should or any hidden folders should be removed.

Theme must not trigger any PHP errors or notices. You're trying to retrieve theme options header_image_layouts, but there is not options for this on Theme Options page, it's options for Thumbnails as Header images. You defined helper function for header image layouts, but added default value for header_post_image. If you correct this I think there won't be any PHP errors.

Also use get_template_directory() instead of TEMPLATEPATH

Resolution not-approved

Last edited 2 years ago by Mamaduka (previous) (diff)
Note: See TracTickets for help on using tickets.