WordPress.org

Make WordPress Themes

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#6954 closed theme (not-approved)

THEME: Museum Core - 1.0

Reported by: jazzs3quence Owned by: chipbennett
Priority: Keywords: theme-museum-core
Cc: chris@…

Description

Museum Core - 1.0

A simple WordPress theme/framework with support for post formats, thumbnails, background, header, menus and more...

Theme URL - http://www.museumthemes.com
Author URL - http://www.arcanepalette.com

SVN - http://themes.svn.wordpress.org/museum-core/1.0
ZIP - http://wordpress.org/extend/themes/download/museum-core.1.0.zip?nostats=1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-museum-core

https://themes.svn.wordpress.org/museum-core/1.0/screenshot.png

Attachments (4)

theme-options.php (15.7 KB) - added by jazzs3quence 6 years ago.
/inc/theme-options.php
header.php (3.6 KB) - added by jazzs3quence 6 years ago.
header.php
readme.txt (10.2 KB) - added by jazzs3quence 6 years ago.
readme.txt
style.css (34.7 KB) - added by jazzs3quence 6 years ago.
style.css

Download all attachments as: .zip

Change History (12)

@jazzs3quence
6 years ago

/inc/theme-options.php

@jazzs3quence
6 years ago

header.php

@jazzs3quence
6 years ago

readme.txt

@jazzs3quence
6 years ago

style.css

#1 @jazzs3quence
6 years ago

made some minor fixes. attached modified files. details in the changelog in readme.txt

#2 @chipbennett
6 years ago

Unfortunately, attaching updates to the ticket won't accomplish anything. If you've revised the Theme, you'll need to upload it using the uploader. A new ticket will be created for the revised Theme.

#3 @chipbennett
6 years ago

  • Owner set to chipbennett
  • Status changed from new to assigned

#4 @chipbennett
6 years ago

  • Resolution set to not-approved
  • Status changed from assigned to closed
  • Footer credit link URL must be either Theme URI or Author URI
  • Footer credit link text, title, etc. must not be SEO-seeded. Please use something more neutral, such as "Museum Themes", rather than "Fine Art WordPress Themes".
  • Translation textdomain must be theme-slug, i.e. museum-core`
  • Translation, if included, must be implemented properly. Strings should be translated as complete phrases, rather than being broken up, e.g.:
    <?php _e('Core is a ','ap_core'); ?><a href="http://wordpress.org" target="_blank">WordPress</a><?php _e(' theme framework by ','ap_core'); ?><a href="http://museumthemes.com/category/free-themes/" target="_blank" title="Museum Themes | Fine Art WordPress Themes">Museum Themes</a>
    
    This string, "Core is a WordPress Theme by Museum Themes'"", should be translated as a complete phrase, using sprintf(). See here for an excellent tutorial:

This is not a complete review.

#5 @jazzs3quence
6 years ago

re: i18n for "Core is a WordPress theme..." -- okay, but how would I go about breaking that up with two links, or does the whole string need to be tweaked so it's just one? Or two separarate phrases (e.g. "museum themes", "powered by WordPress"). There are a couple places that happens in the theme and Otto's tutorial doesn't really go over the specifics other than don't insert HTML markup into the the translation string.

#6 @jazzs3quence
6 years ago

Here's a good example:

<?php _e('Posted in','museum-core'); ?> <?php the_category(', '); ?> <?php the_tags(__('and tagged ','museum-core'),', ',''); ?>

Do I just forsake friendliness ( eg: Categories: Cat A | Tags: foo, bar ) in favor of being better for translations?

Last edited 6 years ago by jazzs3quence (previous) (diff)

#7 follow-up: @chipbennett
6 years ago

Re: footer credit links, you might be better off splitting those up into two separate phrases? Let me research that a bit, and get back to you.

Re: Categories/Tags - no, your current implementation is fine. That's meta information, and not really a "phrase".

#8 in reply to: ↑ 7 @jazzs3quence
6 years ago

Replying to chipbennett:

Re: footer credit links, you might be better off splitting those up into two separate phrases? Let me research that a bit, and get back to you.

OK, cool. Let me know either way. I have less of a problem breaking that up than the "Posted in MyCat and tagged with cats, dogs and gerbils" which reads friendlier than "Category: MyCat | Tags: cats, dogs, gerbils" which is what I was trying to get away from.

Note: See TracTickets for help on using tickets.