WordPress.org

Make WordPress Themes

Opened 6 years ago

Closed 6 years ago

#7099 closed theme (not-approved)

THEME: Museum Core - 1.0.3

Reported by: jazzs3quence Owned by: kobenland
Priority: Keywords: theme-museum-core
Cc: chris@…

Change History (2)

#1 @kobenland
6 years ago

  • Owner set to kobenland
  • Status changed from new to assigned

#2 @kobenland
6 years ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

THEME REVIEW RESULTS

  • Previous version of Theme NOT-APPROVED

Previous Issues from #6980

  • FIXED: Hard-coded charset meta tag.
  • FIXED: Theme's license info should be in the format described in Theme Review guidelines.
  • FIXED: Default header image is missing.
  • FIXED: Undefined variable: plugin_name in \museum-core\inc\theme-options.php on line 401
  • NOT-FIXED: No comments in pages with comments allowed. Page With Comments=> Comment list and comment reply form must be displayed.

Code Quality

  • REQUIRED: Themes are required to use a unique slug as a prefix for anything in the public namespace, including all custom function names, classes, hooks, public/global variables, database entries (Theme options, post custom metadata, etc.)
    • RECOMMENDED: Themes are recommended to use theme-slug as this unique slug => museum_core
  • REQUIRED: No core WordPress functions introduced prior to one previous, major WordPress release (3.2) are wrapped in function_exists() conditionals.
  • REQUIRED: Please hook the Themes widget and sidebar business in 'widget_init'
  • REQUIRED: Please hook ap_core_load_scripts() to 'wp_enqueue_scripts'
  • REQUIRED: No unnecessary meta tags (WordPress generator tag, author meta, description tags etc.) are hard-coded into the document head.
  • REQUIRED: Themes are REQUIRED to use get_template_directory()/get_stylesheet_directory() instead of TEMPLATEPATH/STYLESHEETPATH
  • REQUIRED: Themes are REQUIRED to enqueue comment-reply script via callback, rather than hard-code the enqueue in the HTML document head. Example:
    <?php
    function oenology_enqueue_comment_reply() {
            if ( is_singular() && comments_open() && get_option( 'thread_comments' ) ) {
                    wp_enqueue_script( 'comment-reply' );
            }
    }
    add_action( 'wp_enqueue_scripts', 'oenology_enqueue_comment_reply' );
    
  • REQUIRED: The following code is not necessary in comments.php:
    <?php
    if (!empty($_SERVER['SCRIPT_FILENAME']) && 'comments.php' == basename($_SERVER['SCRIPT_FILENAME']))
        die('Please do not load this page directly. Thanks!');
    
  • REQUIRED: Translation: Use format strings instead of string concatenation — sprintf(__('Replace %s with %s'), $a, $b); is always better than __('Replace ').$a.__(' with ').$b;. See I18n for WordPress Developers. Please check entire theme.
  • REQUIRED: Themes need to show "Comments are closed" message on all post types, except pages, where it must not be displayed.
  • REQUIRED: Themes are REQUIRED to use the wp_title filter, to filter wp_title() (RECOMMENDED), or pass argument to wp_title() (OPTIONALLY), in order to modify document title content
  • REQUIRED: Since Theme supports translation, all strings (including searchform) must be translatable
  • REQUIRED: Theme are required to implement Theme Options and Theme Settings pages deliberately, rather than relying on copy-and-paste scripts from website tutorials.
  • REQUIRED: For checkboxes and select options, Themes are required to use the checked() and selected() functions for outputting checked="checked" and selected="selected", respectively.
  • REQUIRED: Please remove commented development code
  • REQUIRED: esc_attr_e() is a translation function. Please use echo esc_attr() for printing escaped values.


Review Summary

  • This was not a complete review.
  • Theme has required issues (see above)
  • Ticket being resolved as NOT-APPROVED. Please address required issues in next Theme revision.

Thank you for your contribution! :)
Konstantin


Please note: (copied in parts from SeizedPropaganda)

  • Theme will be held for approval until items listed as REQUIRED are addressed. Once these issues have been resolved, please re-submit your Theme using the uploader tool on wordpress.org, and a new Trac ticket will be generated.
  • Re-submitted Themes are given review priority over new Themes. Any review-based Theme revision that is submitted within two days of the previous review and linked to from the previous ticket will be accepted by the previous-ticket reviewer, and the review continues on the new ticket.
  • The Theme Review Team will no longer emphasize complete and thorough reviews, and will instead close tickets upon observation of any non-trivial issues.
  • Themes should be reviewed using define( 'WP_DEBUG', true ); in wp-config.php
  • Theme developer questions, comments, and feedback are welcome and encouraged. Please use one of the following methods:
    1. Leave a comment on this ticket
    2. Email the theme-reviewers email list
    3. Use the #wordpress-themes channel on irc.freenode.net
Note: See TracTickets for help on using tickets.