WordPress.org

Make WordPress Themes

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#7197 closed theme (not-approved)

THEME: Pure Line - 1.0.0

Reported by: Romik84 Owned by: kobenland
Priority: Keywords: theme-pure-line
Cc: senditme@…

Description

Pure Line - 1.0.0

Professional, clean yet amazing WordPress theme for enthusiasts of simplicity and flexibility. Pure Line, with over 40 theme options, is the top WordPress theme for todays bloggers needs. You have full control over the layout, post excerpts with thumbnails, post boxes, up to 8 subscribe/social customizable buttons, custom logo uploading, 8 header and footer widgets, pre-installed font styles, custom CSS, built-in custom header and background, and ready-made ads spaces. With customizable post rows, Pure Line is the best solution for any blog or magazine website. The theme also fully supports custom Menus. Translated in Spanish, German, Swedish, Dutch, French, Russian, Turkish, Norwegian, Slovenian, Italian, Brazilian Portuguese. The best, it's absolutely free! Designed by <a href="http://theme4press.com">http://theme4press.com</a>

Theme URL - http://theme4press.com/pure-line
Author URL - http://theme4press.com

SVN - http://themes.svn.wordpress.org/pure-line/1.0.0
ZIP - http://wordpress.org/extend/themes/download/pure-line.1.0.0.zip?nostats=1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-pure-line

https://themes.svn.wordpress.org/pure-line/1.0.0/screenshot.png

Change History (9)

#1 @kobenland
6 years ago

  • Owner set to kobenland
  • Status changed from new to assigned

#2 @kobenland
6 years ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

THEME REVIEW RESULTS

Code Quality

  • REQUIRED: Since Theme supports i18n, all strings must be translatable:
    • library/functions/comments.php
    • functions.php

Theme Unit Test

  • REQUIRED: "Comments are disabled" notice must be displayed on posts (not pages), when comments are closed.
  • Themes are REQUIRED to use get_template_directory()/get_stylesheet_directory() instead of TEMPLATEPATH/STYLESHEETPATH. Please use also get_template_directory() rather than WP_CONTENT_URL . '/themes/pureline/[...]'
  • REQUIRED: Themes are REQUIRED to use core-bundled versions of jQuery UI and jQuery UI Plugins
  • REQUIRED: Themes are required to use a unique slug as a prefix for anything in the public namespace, including all custom function names, classes, hooks, public/global variables, database entries (Theme options, post custom metadata, etc.)
  • REQUIRED: Please use delete_option() rather than a custom query.
  • REQUIRED: No core WordPress functions introduced prior to one previous, major WordPress release (3.2) are wrapped in function_exists() conditionals.
  • REQUIRED: Themes are required to use esc_attr() for text inputs and esc_html() or esc_textarea() for textareas.
  • REQUIRED: For checkboxes and select options, Themes are required to use the checked() and selected() functions for outputting checked="checked" and selected="selected", respectively.
  • REQUIRED: Themes are REQUIRED to enqueue comment-reply script via callback, rather than hard-code the enqueue in the HTML document head. Example:
        <?php
        function oenology_enqueue_comment_reply() {
            if ( is_singular() && comments_open() && get_option( 'thread_comments' ) ) { 
                    wp_enqueue_script( 'comment-reply' ); 
            }
        }
        add_action( 'wp_enqueue_scripts', 'oenology_enqueue_comment_reply' );
        ?>
    
  • REQUIRED: Themes are REQUIRED to use 'wp_title' filter, to filter wp_title() (RECOMMENDED), or pass argument to wp_title() (OPTIONALLY), in order to modify document title content
  • REQUIRED: No CSS files other than style.css are hard-coded into the document head. (These files must either be enqueued and hooked in appropriately, or added using IE conditional tags.)


Review Summary

  • This was not a complete review.
  • Theme has required issues (see above)
  • Ticket being resolved as NOT-APPROVED. Please address required issues in next Theme revision.

Thank you for your contribution! :)
Konstantin


Please note: (copied in parts from SeizedPropaganda)

  • Theme will be held for approval until items listed as REQUIRED are addressed. Once these issues have been resolved, please re-submit your Theme using the uploader tool on wordpress.org, and a new Trac ticket will be generated.
  • Re-submitted Themes are given review priority over new Themes. Any review-based Theme revision that is submitted within two days of the previous review and linked to from the previous ticket will be accepted by the previous-ticket reviewer, and the review continues on the new ticket.
  • The Theme Review Team will no longer emphasize complete and thorough reviews, and will instead close tickets upon observation of any non-trivial issues.
  • Themes should be reviewed using define( 'WP_DEBUG', true ); in wp-config.php
  • Theme developer questions, comments, and feedback are welcome and encouraged. Please use one of the following methods:
    1. Leave a comment on this ticket
    2. Email the theme-reviewers email list
    3. Use the #wordpress-themes channel on irc.freenode.net

#3 @Romik84
6 years ago

thank you for the review. please might you give me a point which need to be translated in the comments.php and functions.php file? some examples. thanks.

#4 @kobenland
6 years ago

Sure,

in pureline_discussion_rss() the link title for example,
in pursimilar_posts() the 'Untitled'.

I know it is technically not required, but think about making the admin strings translatable as well.

Konstantin

#5 @Romik84
6 years ago

hi again,

I am still not sure about these two points:

Themes are REQUIRED to use 'wp_title' filter, to filter wp_title() (RECOMMENDED), or pass argument to wp_title() (OPTIONALLY), in order to modify document title content

No CSS files other than style.css are hard-coded into the document head. (These files must either be enqueued and hooked in appropriately, or added using IE conditional tags.)

  • my theme uses the wp_title filter in the header.php. Should I modify that yet?
  • as you mentioned the theme should use IE conditions for custom CSS. The theme uses them in the custom-css.php file which I call with the get_template_part() function as a reviewer recommended me this call in my other template. So, should I copy all those conditional tags to the header instead? thanks for answer

#6 @kobenland
6 years ago

Hi,

no problem, I'm here to help! :)

  • Styles: ALL stylesheets must be enqueued (from functions.php). Exceptions:
    • style.css
    • IE specific stylesheets that are wrapped in IE conditionals

So rather than using get_template_part() here, you should hook a function to 'wp_enqueue_scripts' and determine there which stylesheet to use and enqueue it then with wp_enqueue_style().

Konstantin

#7 follow-up: @Romik84
6 years ago

should I create a css file for every custom CSS? If I have one line

<style type="text/css">#backtotop {left:3%;margin-left:0;} </style>

and more such lines in the custom-css.php should I create all CSS files and call them through wp_enqueue_style() function? I am kinda confused how else I could call those custom sheets

#8 in reply to: ↑ 7 @kobenland
6 years ago

Replying to Romik84:

should I create a css file for every custom CSS? If I have one line

No, I don't think this is really necessary.

should I create all CSS files and call them through wp_enqueue_style() function? I am kinda confused how else I could call those custom sheets

Well, I suppose the way you hande inline CSS could be retained. All <link> stylesheets must definitely be enqueued. If you want to make it really awesome, you could use wp_add_inline_style() to append the chosen font etc to the already enqueued main stylesheet.

Konstantin

#9 @Romik84
6 years ago

thank you for the function. I was looking for this long time, but unfortunately there is no guide on this function. I hope I can handle this correctly :)

Note: See TracTickets for help on using tickets.