WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

#7248 closed theme (closed-newer-version-uploaded)

THEME: Sunspot - 1.0

Reported by: automattic Owned by: jr.duboc
Priority: Keywords: theme-sunspot
Cc: themes@…

Description

Sunspot - 1.0

A sharp theme with subtle grid lines and sun-splashed accents, Sunspot is a great all-purpose blogging canvas, especially for those who prefer a dark color scheme. Sunspot offers two arrangements for posts on the front page. Additional features include a custom header and a custom background, two optional widget areas, and a responsive layout that adapts gracefully to smaller screen sizes.

Theme URL - http://theme.wordpress.com/themes/sunspot
Author URL - http://automattic.com/

SVN - http://themes.svn.wordpress.org/sunspot/1.0
ZIP - http://wordpress.org/extend/themes/download/sunspot.1.0.zip?nostats=1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-sunspot

https://themes.svn.wordpress.org/sunspot/1.0/screenshot.png

Change History (10)

comment:1 jr.duboc2 years ago

  • Owner set to jr.duboc
  • Status changed from new to accepted

comment:2 jr.duboc2 years ago

Hi,
haven't have time to check the theme in detail tonight.
However I can already see two deprecated function calls due to the recent changes in the background and header image functions for WP 3.4. : http://make.wordpress.org/themes/2012/04/06/updating-custom-backgrounds-and-custom-headers-for-wordpress-3-4/
You'll need to use

add_theme_support( 'custom-background', $args )

and

add_theme_support( 'custom-header', $args )

I'll let you know if I find anything more than that tomorrow.

I like the theme, though, it looks pretty slick and the mobile version is nice too :)

Last edited 2 years ago by jr.duboc (previous) (diff)

comment:3 automattic2 years ago

Thanks so much! Yep, I'll get the header and background functions updated, but will wait for your other feedback so that I can submit the changes in one new ticket.

comment:4 jr.duboc2 years ago

Hi,
so all in all nothing really major, just a few very small things I noticed:

  • you added a XFN profile, which is required EXCEPT in HTML5 (it doesn't support it). Sunspot seems to be in HTML5, so there shouldn't be an XFN profile.
  • the .sticky class is not supported. It can be empty, but they are required to show that all classes generated by WordPress are taken into account.
  • The licence URI in the style.css should read:


License URI: http://www.gnu.org/licenses/gpl-2.0.html

instead of

License URI: license.txt

As it is at the moment.'

So, there it is, seems to be ready as soon as these small problems are fixed :)

comment:5 jr.duboc2 years ago

  • Resolution set to not-approved
  • Status changed from accepted to closed

comment:6 automattic2 years ago

Great, thanks for the feedback. I'll fix these issues and will link to the new ticket as soon as I've done so.

comment:7 follow-up: jr.duboc2 years ago

Did you have the chance to update the theme yet? I haven't seen the link....

comment:8 in reply to: ↑ 7 automattic2 years ago

Yep, I've just submitted an update. The new ticket is: http://themes.trac.wordpress.org/ticket/7532

Thanks!

comment:9 jr.duboc2 years ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

comment:10 jr.duboc2 years ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.