WordPress.org

Make WordPress Themes

Change History (2)

comment:1 emiluzelac2 years ago

  • Owner set to emiluzelac
  • Status changed from new to assigned

comment:2 emiluzelac2 years ago

  • Resolution set to not-approved
  • Status changed from assigned to closed
<span style="color:#c0c0c0;">
<div style="margin-bottom:8px;">

etc, please remove styles similar to this and add them in your stylesheet. When you embed styles they will be impossible to overwrite.

Remove completely

//error_reporting(E_ALL);
//ini_set('display_errors', '1');

this is also not how debug should be anyways, you can simply open your wp-config.php and change wp_debug to true

/**
 * For developers: WordPress debugging mode.
 *
 * Change this to true to enable the display of notices during development.
 * It is strongly recommended that plugin and theme developers use WP_DEBUG
 * in their development environments.
 */
define('WP_DEBUG', true);

JS should not be used like this

<script src="<?php echo get_template_directory_uri() ?>/jquery-1.7.2.min.js" type="text/javascript"></script>
<script type="text/javascript">
function mainmenu(){
$(" #nav a").removeAttr("title");
$(" #nav ul ").css({display: "none"}); // Opera Fix
$(" #nav li").hover(function(){
		$(this).find('ul:first').css({visibility: "visible",display: "none"}).show(0);
		},function(){
		$(this).find('ul:first').css({visibility: "hidden"});
		});
}
$(document).ready(function()
{
	mainmenu();
});
</script>

please add the functions into example.js and call them from functions.php also there's no need to add jQuery, WordPress handles this pretty nicely.


There's more than enough items that must be corrected before next submission. If you have any questions please ask them here, you can also visit Theme Review for more details about this review.

Note: See TracTickets for help on using tickets.