WordPress.org

Make WordPress Themes

Change History (5)

comment:1 kobenland2 years ago

  • Owner set to kobenland
  • Status changed from new to accepted

comment:2 kobenland2 years ago

  • Resolution set to not-approved
  • Status changed from accepted to closed

Hi Herold,

Themes don't find more attention, the more open tickets they have. Please note that the Theme Review Team is comprised entirely of volunteers who perform reviews during their free time so the turnaround time is variable.

Thanks for your patience.


THEME REVIEW RESULTS

  • Previous version of Theme NOT-APPROVED

Previous Issues from #7627

  • FIXED: Theme URL - http://hdbolierplate.com does not exist, domain name is not even registered yet
  • FIXED: Images such as ArvhokICIAIKrNL.jpg should be within a /images/ folder
  • FIXED: Theme looks based on Starkers, please note that you must carry on their license https://github.com/nathanstaines/starkers-html5/blob/master/LICENSE.md as well as either leave or add the copyright reference to this Theme. GPL license requires that credits are left or if not you will need to add them in your Theme.
  • FIXED: /languages/ folder contains Starkers reference.
  • FIXED: Style embedding is bad coding practice
  • PARTLY-FIXED: license.txt is empty
    • While there is no specific guidline regarding this, but license.txt is the place for the actual license text.

Code Quality

  • Themes are REQUIRED to spell "WordPress" correctly in all public facing text: all one word, with both an uppercase W and P.
  • Themes are REQUIRED to use the 'edit_theme_options' capability for add_theme_page(), rather than rely on a role (e.g. "administrator"), or a different capability (e.g. "edit_themes", "manage_options") for the capability to add the settings page.
  • Themes are REQUIRED to save options in a single array, rather than create multiple options for its settings page. Use of set_theme_mod and get_theme_mod handles this for you, as does using the Settings API.
  • Themes are REQUIRED to validate and sanitize all untrusted data before entering data into the database, and to escape all untrusted data before being output in the Settings form fields or in the Theme template files
  • For checkboxes and select options, Themes are REQUIRED to use the checked() and selected() functions for outputting checked="checked" and selected="selected", respectively.
  • Themes are REQUIRED to use the Theme-specific hook for admin-enqueued scripts/stylesheets, e.g. admin_enqueue_script-appearance_page_$menu_slug
  • REQUIRED: Please remove from comments.php:
    <?php
    // Do not delete these lines
    if (!empty($_SERVER['SCRIPT_FILENAME']) && 'comments.php' == basename($_SERVER['SCRIPT_FILENAME']))
            die ('Please do not load this page directly. Thanks!');
    
  • Themes are REQUIRED to use get_template_directory()/get_stylesheet_directory() instead of TEMPLATEPATH/STYLESHEETPATH

Theme Unit Test

  • REQUIRED: On 404 pages: Some content must be displayed, more than merely the basic "Error 404 - Page Not Found" message - such as some helpful text, a search form, a list of Post or Pages, etc.


Review Summary

  • This was not a complete review.
  • Theme has required issues (see above)
  • Ticket being resolved as NOT-APPROVED. Please address required issues in next Theme revision.

Thanks,
Konstantin


Please note: (copied in parts from SeizedPropaganda)

  • Theme will be held for approval until items listed as REQUIRED are addressed. Once these issues have been resolved, please re-submit your Theme using the uploader tool on wordpress.org, and a new Trac ticket will be generated.
  • Re-submitted Themes are given review priority over new Themes. Any review-based Theme revision that is submitted within two days of the previous review and linked to from the previous ticket will be accepted by the previous-ticket reviewer, and the review continues on the new ticket.
  • The Theme Review Team will no longer emphasize complete and thorough reviews, and will instead close tickets upon observation of any non-trivial issues.
  • Themes should be reviewed using define( 'WP_DEBUG', true ); in wp-config.php
  • Theme developer questions, comments, and feedback are welcome and encouraged. Please use one of the following methods:
    1. Leave a comment on this ticket
    2. Email the theme-reviewers email list
    3. Use the #wordpress-themes channel on irc.freenode.net

comment:3 hxf1482 years ago

Thanks for the info on the wait time. Just curious if I had slipped into the void.

I am correcting the issues you have indicated. Thanks for helping to make the theme better.

Cheers,
Harold

comment:4 hxf1482 years ago

Oh and the reason for a second upload was I noticed that the theme image needed a correction.. not to bump. Next time I will wait for an action before proceeding to a new version.

comment:5 kobenland2 years ago

No need, it is perfectly fine to upload a new version, when more than the theme version number has changed. ;)

Konstantin

Note: See TracTickets for help on using tickets.