WordPress.org

Make WordPress Themes

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#7927 closed theme (not-approved)

THEME: Firstyme - 1.3.3

Reported by: charlieasemota Owned by: kobenland
Priority: Keywords: theme-firstyme
Cc: charlie.e.asemota@…

Change History (4)

#1 @kobenland
5 years ago

  • Owner set to kobenland
  • Status changed from new to accepted

#2 @kobenland
5 years ago

THEME REVIEW RESULTS

  • Previous version of Theme NOT-APPROVED

Previous Issues from #7802

  • FIXED: Title anchor in 404.php and search.php are obsolete
  • FIXED: Credit link text needs to be revised.
  • FIXED: The following template tags and hooks are required to be included where appropriate posts_nav_link(), or previous_posts_link()/next_posts_link() (on single posts)
  • NOT-FIXED: For checkboxes and select options, Themes are required to use the checked() and selected() functions.
    • Please have a look at the documentation of checked() and selected() to learn more about their functionality (they need to get an argument passed to them)
  • REQUIRED: Please do not claim copyright for the entire site as a default in footer.php

Code Quality

  • REQUIRED: Please change the textdomain in the post navigation links, added in singele.php


Review Summary

  • Diff review only.
  • Theme has required issues (see above)

We're almost there Charlie, I can't wait to approve this Theme! :)

Please make sure you tested the Theme with the Theme Unit Test prior to resubmission and checked that the options work.

I'll keep this ticket open for a couple of days. Please address above mentione required issue. Once you've re-submitted your theme, please comment here with the link to the new trac ticket.

Thanks,
Konstantin


  • Theme developer questions, comments, and feedback are welcome and encouraged. Please use one of the following methods:
    1. Leave a comment on this ticket
    2. Email the theme-reviewers email list
    3. Use the #wordpress-themes channel on irc.freenode.net

#3 @kobenland
5 years ago

  • Resolution set to not-approved
  • Status changed from accepted to closed
Note: See TracTickets for help on using tickets.