WordPress.org

Make WordPress Themes

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#7949 closed theme (live)

THEME: Polaroids - 1.41

Reported by: webdesignuk Owned by: Fingli
Priority: Keywords: theme-polaroids
Cc: info@…

Change History (4)

#1 @webdesignuk
5 years ago

I've just added the transparent PNG file so users have the option to edit
the graphic as they wish.

Also, assuming the theme is approved (has already been approved once) - just
wondering how long it is until it's added to the official WordPress theme
directory?

Thanks in advance

Guy

#2 @Fingli
5 years ago

  • Owner set to Fingli
  • Status changed from new to assigned

#3 @Fingli
5 years ago

  • Resolution set to approved
  • Status changed from assigned to closed

Tested. This version works well and can be approved with few remarks for future improvement.

  • Presence of hard-coded favicon which is not recommended by Theme Review Guidelines

    Themes are recommended not to implement custom favicon functionality.

    If implemented, favicon functionality is required to be opt-in, and disabled by default.

  • The theme in general is translation-ready but in some strings there are no textdomain or it's not theirs own - like 'buttercream'

Example:

In functions.php

<?
/** A safe way of adding javascripts to a WordPress */
   if (!is_admin())
        add_action('wp_enqueue_scripts', 'polaroids_js');
                
        function polaroids_js() {
        wp_enqueue_script( 'mootools', get_template_directory_uri() . '/js/mootools.js' );      
        wp_enqueue_script( 'script', get_template_directory_uri() . '/js/script.js' );
        wp_enqueue_script( 'mootools-more', get_template_directory_uri() . '/js/mootools-more.js' );
}
?>

Theme Approval

The Trac ticket for your Theme has been approved, and your Theme is now ready to be synchronized to Extend, after which it will be available publicly.

Please note: the synchronization process from SVN to Extend is manual, and generally completed by a WPTRT admin on a daily basis. Your Theme may take a day or two to go "live" in Extend. Thank you for your patience in this final step of the process!

Responding To This Review

Theme developer questions, comments, and feedback are welcome and encouraged. Please use one of the following methods:

#4 @webdesignuk
5 years ago

Thanks for your help on this - shall look at these alterations for the next version :)

Note: See TracTickets for help on using tickets.