WordPress.org

Make WordPress Themes

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#814 closed theme (not-approved)

THEME: Matala - 1.0

Reported by: themetracbot Owned by: chipbennett
Priority: Keywords: theme-matala,
Cc:

Description

Matala - 1.0

Theme for ma.tt, beginning March 2008.

Theme URL - http://ma.tt
Author URL - http://www.gnvpartners.com

SVN - http://themes.svn.wordpress.org/matala/1.0

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-matala

Change History (6)

#1 @matt
7 years ago

I bumped this so I could use it in a presentation later today, but will do an iteration based on theme reviewer team's feedback.

#2 @chipbennett
7 years ago

  • Owner set to chipbennett
  • Status changed from new to assigned

#3 @chipbennett
7 years ago

  • Resolution set to not-accepted
  • Status changed from assigned to closed

Required:

Please grep and replace all hard-coded http://ma.tt URL references. (I found one, in index.php, in the gallery category conditional code; I didn't look for others.)

Code Quality: Fails CSS validation

  • note: vendor-prefix property errors are acceptable
  • note: validator shows error on Ln 72 (text-shadow), but it looks valid to me
  • Line 1056: remove comma from declaration

Hooks,Tags,Functions:

  • includes add_theme_support('post-thumbnails'), but does not include a call to the_post_thumbnail() anywhere in the Loop.
  • post_class() omitted in single.php
  • paginate_comments_links() (or previous_comments_link()/next_comments_link()) omitted from comments.php

Theme Unit Tests: General

  • space available for primary nav menu only allows for ~5 (short) page names, and overflow is not handled well (page names overflow on top of/around the first Post Title, and obscure its link)

Layout Test:

  • HTML tags not styled: TABLE (TH, TR, TD), ABBR, ACRONYM

Images Test:

  • Left-align and Right-align on images work differently (right-align floats around paragraph text; left-align doesn't).
  • Over-sized images being cropped, rather than resized proportionally to fit within $content_width

Strongly Recommended, not Required

post_class() is not included for the gallery category, but is included for all others. Is this omission necessary?

in sidebar.php, conditional for dynamic_sidebar does not include ( ! function_exists( 'dynamic_sidebar' ) )

Comments Test: reply to author comment inherits author-comment style

#4 @Frumph
7 years ago

Chip: You do not need !function_exists('dynamic_sidebar when you're not making a backward compatible theme.

Those HTML Tags are not a required to be styled., the base of them is sufficient.

#5 @Otto42
7 years ago

I'm correcting these errors along with several others and will be resubmitting it later today.

#6 @Otto42
7 years ago

Done. Reference #906.

Note: See TracTickets for help on using tickets.