WordPress.org

Make WordPress Themes

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#840 closed theme (closed-newer-version-uploaded)

THEME: ClassRoom Blog - 1.05

Reported by: themetracbot Owned by: greenshady
Priority: Keywords: theme-classroom-blog,
Cc: dan@…

Description

ClassRoom Blog - 1.05

ClassRoom Blog is a free wordpress theme for Teachers and Educators to use for a class blog. Elementary, Middle, Highschool and College Professors have the ability to customize an easy to work with education related theme. This theme is released under GPL, GNU.

Theme URL -
Author URL - http://apepperdesigns.com

SVN - http://themes.svn.wordpress.org/classroom-blog/1.05

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-classroom-blog

Change History (14)

#1 @greenshady
7 years ago

Some suggestions for improvement:

  • Use language_attributes() in <html> element.
  • Use home_url() instead of get_bloginfo( 'url' ) in header.php, sidebar.php.
  • Use wp_nav_menu() instead of wp_list_pages().
  • Internationalize text strings.
  • Use body_class().
  • Use post_class().
  • Use esc_attr() instead of wp_specialchars() in searchform.php.
  • Use home_url() instead of $_SERVER in searchform.php.
  • Use date( 'Y' ) instead of "2009" for the copyright date in footer.php.
  • Use post_password_required() instead of $post->post_password in comments.php.
  • No need for the unused $oddcomment = 'alt'; in comments.php.
  • Use admin_url( 'profile.php' ) instead of get_option('siteurl'); ?>/wp-admin/profile.php in comments.php.
  • Use comment_form() instead of manually creating the HTML for this.
  • Theme URI in style.css is invalid: hhttp://apepperdesigns.com/wordpress/.
  • No need for a function_exists('dynamic_sidebar') check in sidebar.php.

Many of these things are covered on the Theme Review page in more detail with links to helpful articles in the Codex.
http://codex.wordpress.org/Theme_Review

#2 @c3mdigital
7 years ago

  • Cc dan@… added

#3 @c3mdigital
7 years ago

Dan,
I added you as a cc on the ticket so you can have a chance to discuss any of the above with the reviewer.

#4 @c3mdigital
7 years ago

I noticed that the author link goes to a sunglass accessory and review blog. It could be considered spammy by some. Just thought I should mention that.

#5 follow-up: @ryanhellyer
7 years ago

I think it would be a good idea to fix the $_SERVERPHP_SELF?.

Potential solutions may include escaping it with esc_url() or just leaving that field blank.

#6 in reply to: ↑ 5 @ryanhellyer
7 years ago

... or use home_url as suggested by Justin above.

#7 @chipbennett
7 years ago

  • Owner set to greenshady
  • Status changed from new to assigned

#8 @apepperdesigns
7 years ago

Thanks for all of the input.

I have one question. I have taken care of pretty much all of my errors except for my post_class(). I know it is similar to body_class(), however I cannot find a good explanation for it anywhere on wordpress.org.

It's been a couple of years since I've done this, any further help is appreciated! Thanks again.

#9 @apepperdesigns
7 years ago

Also, I run into errors removing my function_exists('dynamic_sidebar') from my sidebar.php There is no invalid markup, and the loop ends....

#10 @apepperdesigns
7 years ago

  • Owner changed from greenshady to apepperdesigns
  • Status changed from assigned to accepted

#11 @chipbennett
7 years ago

  • Owner changed from apepperdesigns to greenshady
  • Status changed from accepted to assigned

Do not assign your own Theme to yourself, or mark your own Theme as "accepted". To do so is a clear conflict of interest.

#12 @chipbennett
7 years ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from assigned to closed

New Version Uploaded: see Ticket #991

#13 @apepperdesigns
7 years ago

Apologies. I thought I had to accept the ticket when I submitted a revision. Thank you.

#14 @chipbennett
7 years ago

No worries; I saw the new ticket come in, and then realized what you were trying to do (I think).

For future reference: when uploading a new version of a Theme in the review queue:

1) Put a comment in the ticket for the old version, linking to the ticket for the new version.
2) Close the old ticket as closed-newer-version-uploaded

Accepted means that the Theme has passed review, and is marked for inclusion in the repository.

Note: See TracTickets for help on using tickets.