WordPress.org

Make WordPress Themes

#8639 closed theme (not-approved)

THEME: ZyRed - 3.0.3

Reported by: TimZ Owned by: garinungkadol
Priority: Keywords: theme-zyred
Cc: tim.zylinski@…

Description

ZyRed - 3.0.3

ZyRed is a three column WordPress theme with flexible width. The content column has a minimum width of 468 pixel, making the theme well prepared for ad placement.

Theme URL - http://www.zyblog.de/wordpress-themes/zyred/
Author URL - http://www.zyblog.de/

SVN - http://themes.svn.wordpress.org/zyred/3.0.3
ZIP - http://wordpress.org/extend/themes/download/zyred.3.0.3.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/zyred/3.0.2&new_path=/zyred/3.0.3

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-zyred&order=id

https://themes.svn.wordpress.org/zyred/3.0.3/screenshot.png

Attachments (3)

child-link-long-text.jpg (16.2 KB) - added by garinungkadol 21 months ago.
default-menu.jpg (63.2 KB) - added by garinungkadol 21 months ago.
gallery.jpg (49.3 KB) - added by garinungkadol 21 months ago.

Download all attachments as: .zip

Change History (5)

comment:1 garinungkadol21 months ago

  • Owner set to garinungkadol
  • Status changed from new to assigned

garinungkadol21 months ago

garinungkadol21 months ago

comment:2 garinungkadol21 months ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

Issues from Previous Review #5600

  • FIXED: No more PHP errors in comments.
  • FIXED: Images and content is no longer cut-off due to a lack of minimum content width.
  • FIXED: Images with center alignment are displayed properly.
  • FIXED: Images with captions are displayed properly.
  • FIXED: Ordered and unordered lists display properly
  • FIXED: Long text does not break the sidebar layout

Theme Unit Tests

Index View

  • REQUIRED: Since you are displaying post content instead of excerpts in index views, you must include wp_link_pages() in the index.php template.
  • REQUIRED: For posts without a title, you must include the permalink to the single post view.

Single Post View

  • REQUIRED: Check the styling of gallery posts. It appears that image notes is causing the gallery display to change. See gallery.jpg


Pages

  • REQUIRED: If comments are disabled, you must not display any kind of "comments are closed" message.

Navigation Menu

  • REQUIRED: Check the styling of the default menu when no navigation menu has been defined. See default-menu.jpg
  • REQUIRED: Check the styling of child links in the navigation menu. Text will break out of the colored box. See child-link-long-text.jpg

CODE QUALITY

  • REQUIRED: Themes are required to enqueue all stylesheets and scripts, using wp_enqueue_style() /wp_enqueue_script(), and hooked into an appropriate hook via callback function, rather than hard-coding stylesheet/script links or tags in the template.
    • Only the theme's style.css may be hard-coded in the header template. All other styles must be properly enqueued.
    • Enqueued scripts should not be placed in the header template. Place them in a function that hooks into wp_enqueue_scripts.
  • REQUIRED: Check template files. There are some text that are not localized.
  • REQUIRED: When displaying the post title in a "title" attribute, use the_title_attribute() instead of the_title().

For example:

<a href="<?php the_permalink() ?>" rel="bookmark" title="<?php _e('Permanent Link to','zyred'); ?> <?php the_title(); ?>"><?php the_title(); ?></a>

can be

<?php
	printf( __( '<a href="%1$s" rel="bookmark" title="%2$s">%3$s</a>', 'zyred' ),
		esc_url( get_permalink() ),
		sprintf( __( 'Permanent Link to %s', 'zyred' ), the_title_attribute( array('echo' => false)  )),
		get_the_title()
	);
?>

Review Summary

  • Theme is previously 'not-approved'.
  • Outstanding issues have been corrected.
  • It has been 8 months since the last review so a complete review was performed.
  • Ticket is being resolved as not-approved due to above issues.

If you have any question about this review, feel free to ask here.

Note: See TracTickets for help on using tickets.