WordPress.org

Make WordPress Themes

Opened 21 months ago

Closed 21 months ago

Last modified 21 months ago

#8844 closed theme (not-approved)

THEME: Cakifo - 1.4.2

Reported by: Jayjdk Owned by: garinungkadol
Priority: Keywords: theme-cakifo
Cc: kontakt@…

Description

Cakifo - 1.4.2

Cakifo is a nice, responsive theme built from the rock-solid Hybrid Core theme framework. With its HTML5 markup and support for all the WordPress features you love, it might be the perfect theme and a great starting point for your blog! Other features include a homepage template, content slider, post formats, improved widgets and many more useful features. Customize it with a custom background, logo and link color or use a child theme. The theme is very child theme friendly.

Theme URL - http://wpthemes.jayj.dk/cakifo
Author URL - http://jayj.dk

SVN - http://themes.svn.wordpress.org/cakifo/1.4.2
ZIP - http://wordpress.org/extend/themes/download/cakifo.1.4.2.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/cakifo/1.4.1&new_path=/cakifo/1.4.2

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-cakifo&order=id

https://themes.svn.wordpress.org/cakifo/1.4.2/screenshot.png

Attachments (1)

wide-image-resized.jpg (40.2 KB) - added by garinungkadol 21 months ago.

Download all attachments as: .zip

Change History (8)

comment:1 garinungkadol21 months ago

  • Owner set to garinungkadol
  • Status changed from new to assigned

comment:2 garinungkadol21 months ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

Hi Jayj.
Thank you for your submission. Just a few things for you to look into before you theme can be approved.

I do have a question about the additional shortcodes you have provided. Are they intended to be used for the "Footer" option in "Theme Settings"? Or are they intended to be used in posts?
If they are intended to be used in posts you will need to provide a plugin that contains these shortcodes. This way if a user switches themes, they can still make use of the shortcode functionality.

Theme Unit Tests

Single Post View

WordPress 3.4 Compatibility

  • RECOMMENDED: get_theme_data found in the file core.php. Deprecated since version 3.4. Use wp_get_theme() instead.
    Line 181: * having to run through the get_theme_data() function again.
    
Line 187: function hybrid_get_theme_data( $path = 'template' ) {
Line 193: /* If the parent theme data isn't set, grab it with the get_theme_data() function. */

REVIEW SUMMARY

  • This is a new theme
  • Ticket is being resolved as NOT-APPROVED due to above issues

If you have any questions about this review, feel free to ask here.

comment:3 follow-up: Jayjdk21 months ago

Hello garinungkadol,

Thanks for the review!

Yes, the shortcodes are for use in the footer content, text widgets, and theme files only. Not in posts/pages. What I mean with theme files are that the theme and child themes can use <?php echo apply_atomic_shortcode( 'entry_title', '[entry-title]' ); ?>

About the image:
I know it's resized in the editor but the image has the size-full class. Why on earth would people use the size-full class on an image and when resize it? (Both TwentyEleven and TwentyTwelve fails that test)

comment:4 in reply to: ↑ 3 garinungkadol21 months ago

Replying to Jayjdk:

Hello garinungkadol,

Thanks for the review!

Yes, the shortcodes are for use in the footer content, text widgets, and theme files only. Not in posts/pages. What I mean with theme files are that the theme and child themes can use <?php echo apply_atomic_shortcode( 'entry_title', '[entry-title]' ); ?>


That is fine then. I just wanted to make sure.

About the image:
I know it's resized in the editor but the image has the size-full class. Why on earth would people use the size-full class on an image and when resize it? (Both TwentyEleven and TwentyTwelve fails that test)


You're right. After removing the size-full class, the image was properly resized. You can strike that requirement.

comment:5 follow-up: Jayjdk21 months ago

Thank you for the quick reply :) Does this mean that the theme is approved now?

comment:6 in reply to: ↑ 5 garinungkadol21 months ago

Replying to Jayjdk:

Thank you for the quick reply :) Does this mean that the theme is approved now?


I'm not certain if I can re-approve the ticket since it's already been tagged as not-approved.

I suggest you re-upload with a different version number and link to the ticket here and I'll approve the next ticket.

comment:7 Jayjdk21 months ago

Thanks

http://themes.trac.wordpress.org/ticket/8898

The only change is version numbers, updated PHPDocs and translation-files

Note: See TracTickets for help on using tickets.