WordPress.org

Make WordPress Themes

Opened 21 months ago

Closed 20 months ago

Last modified 20 months ago

#8954 closed theme (live)

THEME: Shiro - 1.1.3

Reported by: pixxels Owned by: mercime
Priority: Keywords: theme-shiro
Cc: info@…

Description

Shiro - 1.1.3

Shiro is a clean and minimal three-column CMS and blog theme by pixxels.at. A responsive layout optimizes the theme for mobile devices. You can customize the theme by using your own logo, color and background. For more instructions take a look at the theme's website. Shiro is ready to translate and is available in English and German.

Theme URL - http://shiro.pixxels.at
Author URL - http://www.pixxels.at

SVN - http://themes.svn.wordpress.org/shiro/1.1.3
ZIP - http://wordpress.org/extend/themes/download/shiro.1.1.3.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/shiro/1.1.2&new_path=/shiro/1.1.3

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-shiro&order=id

https://themes.svn.wordpress.org/shiro/1.1.3/screenshot.png

Attachments (1)

01-customhead.png (14.5 KB) - added by mercime 20 months ago.

Download all attachments as: .zip

Change History (4)

comment:1 mercime20 months ago

  • Owner set to mercime
  • Status changed from new to assigned

mercime20 months ago

comment:2 mercime20 months ago

  • Resolution set to approved
  • Status changed from assigned to closed

Issues from Previous Review

  • Fixed. Screenshot should be a "reasonable facsimile" of the Theme after it is initially activated with default options.
  • Fixed. Gallery View - An image with a long description affects the layout
  • Fixed. Single Post View - Check the styling of the comment page navigation. The first comment appears right after it.
  • Fixed. Single Post View - Is the height of the video intended to be so squashed?
  • Fixed. Page - Check the styling of lists when used in pages. If there is a post thumbnail, the numbered items appear on the image
  • Fixed. Page - Check the styling of the "Colored Background, Sidebar" template
  • Fixed. Search Results - You must provide next/previous links in search results.
  • Fixed. Check your template files. You are using the wrong text-domain in archive.php, 'lenora' instead of 'shiro'
  • Fixed. Scripts should not be hard-coded in the header template file. The HTML5 script belongs in a function that hooks into wp_head since you have CSS conditionals.

Minor Issues

#headimg h1 a { 
     line-height: 1;
     text-decoration:none;
}
  • Readme.txt sidebar template file info are mixed up in
    • Template 'Colored Background, No Sidebar" (colored-with-sidebar.php)
    • Template 'Colored Background, Sidebar" (colored-without-sidebar.php)
    • SHOULD BE "Template 'Colored Background, No Sidebar" (colored-without-sidebar.php)" and "Template 'Colored Background, Sidebar" (colored-with-sidebar.php)" respectively

Theme Review Summary

APPROVED on CONDITION that the "OTHER ISSUES" above will be resolved in your next update. Thank you for submitting your theme to the WP Theme Repository.

Please note that the synchronization process from SVN to Extend is manual and will take around a week to do so. In the meantime, please feel free to update and resubmit your theme and post the new ticket here.

comment:3 pixxels20 months ago

Great thank you! Sure I'll resolve the other issues in the next update.

Note: See TracTickets for help on using tickets.