WordPress.org

Make WordPress Themes

Change History (7)

comment:1 emiluzelac20 months ago

  • Owner set to max2501
  • Status changed from new to assigned

comment:2 follow-up: max250120 months ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

Hello c3mdigital,

thanks for submitting your theme.

THEME REVIEW RESULTS

  • Themes are required to have a Correct XFN profile link in <head> tag:
<head profile="http://gmpg.org/xfn/11">
  • Themes are required to use a unique slug as a prefix for anything in the public namespace, including all custom function names, classes, hooks, public/global variables, database entries (Theme options, post custom metadata, etc.) (see functions.php)
  • Themes are required to be 100% GPL-licensed, or use a GPL-compatible license. This includes all PHP, HTML, CSS, images, fonts, icons, and everything else. All of the theme must be GPL-Compatible.
  • Themes are required to declare copyright and license information as specified by the applicable license
  • Since Theme supports translations, all public facing strings must be translatable

THEME UNIT TEST

  • I think h2 and h3 has the same size. h2 must be a little bit bigger. Please fix this in next version.
  • Image Test: Clearing Floats (Make sure any elements after it are clearing properly.)

Review Summary

  • Theme has required issues (see above)
  • This was not a complete review.
  • Ticket being resolved as NOT-APPROVED.

Thanks,
Max


Please note

Please use the following tools to recreate the issues raised above:

Themes should be reviewed using define( 'WP_DEBUG', true ); in wp-config.php

Last edited 20 months ago by max2501 (previous) (diff)

comment:3 in reply to: ↑ 2 c3mdigital20 months ago

Hi Max,
Thank you very much for taking the time to review my theme submission. I do have a few questions and would like some clarification on some of the issues you brought up.

THEME REVIEW RESULTS

  • Themes are required to have a Correct XFN profile link in <head> tag:

Please not that this theme is HTML 5 and XFN Profile links are not supported in HTML 5

see http://codex.wordpress.org/Theme_Review#Doctype_Declaration

<head profile="http://gmpg.org/xfn/11">
  • Themes are required to use a unique slug as a prefix for anything in the public namespace, including all custom function names, classes, hooks, public/global variables, database entries (Theme options, post custom metadata, etc.) (see functions.php)

Everything in the public namespace is prefixed. Could you please be more specific as to your findings here.

  • Themes are required to be 100% GPL-licensed, or use a GPL-compatible license. This includes all PHP, HTML, CSS, images, fonts, icons, and everything else. All of the theme must be GPL-Compatible.

Everything in this theme is 100% GPL compatible including all images, fonts, icons etc.. Did you read the license declarations? http://themes.svn.wordpress.org/wp-unframework/1.2.2/license.txt

  • Themes are required to declare copyright and license information as specified by the applicable license

Again copyright and license information are declared in http://themes.svn.wordpress.org/wp-unframework/1.2.2/license.txt and in style.css

  • Since Theme supports translations, all public facing strings must be translatable

Could you please point out a public facing string that is not translatable? I am pretty sure every single one of them is.

THEME UNIT TEST

  • I think h2 and h3 has the same size. h2 must be a little bit bigger. Please fix this in next version.

This theme is a starter theme with minimal styling. The CSS included is meant to just give basic structure and if you look at the CSS you will see that h2 and h3 have slightly different sizes.

h2 { font-size: 1.4em; }
h3 { font-size: 1.3em; }
h4 { font-size: 1.2em; }
h5 { font-size: 1.1em; }
  • Image Test: Clearing Floats (Make sure any elements after it are clearing properly.)

Review Summary

  • Theme has required issues (see above)
  • This was not a complete review.
  • Ticket being resolved as NOT-APPROVED.

Thanks,
Max


Please note

Please use the following tools to recreate the issues raised above:

Themes should be reviewed using define( 'WP_DEBUG', true ); in wp-config.php

comment:4 max250120 months ago

  1. "Please not that this theme is HTML 5 and XFN Profile links are not supported in HTML 5"
  • Sorry, my fault. :)
  1. "Everything in the public namespace is prefixed. Could you please be more specific as to your findings here."
  • for example
function excerpt_length( $length ) {
		return 65;
	}

	function read_more_link() {
		return '<a href="'.esc_url( get_permalink() ).'" title="'.the_title_attribute( array( 'before' => __( 'Permalink to ', 'wpu' ), 'echo' => false ) ).'" rel="bookmark">'. __( 'Continue <span class="meta-nav">&rarr;</span>', 'wpu' ).'</a>';
	}

  1. "Everything in this theme is 100% GPL compatible including all images, fonts, icons etc.. Did you read the license declarations?"
  • No, I didn't. Lots of themes have these license files, which are mostly a copy of the GPL License. So, sorry.
  1. "Could you please point out a public facing string that is not translatable? I am pretty sure every single one of them is."
  • Yes, of course: searchform.php
<label for="s" class="screen-reader-text">Search for:</label>

Summary

  • FIXED: Themes are required to have a Correct XFN profile link in <head> tag
  • FIXED: Themes are required to be 100% GPL-licensed, or use a GPL-compatible license. This includes all PHP, HTML, CSS, images, fonts, icons, and everything else. All of the theme must be GPL-Compatible.
  • FIXED: Themes are required to declare copyright and license information as specified by the applicable license
  • FIXED: I think h2 and h3 has the same size. h2 must be a little bit bigger. Please fix this in next version.

Please fix all other issues and submit your theme again.

Thanks,
Max

comment:5 c3mdigital20 months ago

Thank you for the quick reply.

All the functions in _/inc/functions.php are inside the class WPU_Functions, they are not in the public namespace. In order to use one of these functions you would have to either declare a new instance of the class i.e.:

$some_var = new WPU_Functions();  
$some_var->excerpt_link();

Or call the functions the way I am in the theme:

Wpu_Functions::excerpt_link();

The object oriented class based functions are described fully in readme.txt.

I forgot about the search form. I will add translation strings and re upload tomorrow.
Again thank you for taking the time to review the theme and for promptly responding to my questions.

comment:6 max250120 months ago

ok, ok.

Don't forget to post the new ticket URL here.

You're welcome.

Thanks,
Max

comment:7 c3mdigital20 months ago

New version uploaded. #9322.

Note: See TracTickets for help on using tickets.