WordPress.org

Make WordPress Themes

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#906 closed theme (not-approved)

THEME: Matala - 1.1

Reported by: themetracbot Owned by: Frumph
Priority: Keywords: theme-matala,
Cc: m@…, otto@…

Description

Matala - 1.1

Theme for ma.tt, beginning March 2008.

Theme URL - http://ma.tt
Author URL - http://www.gnvpartners.com

SVN - http://themes.svn.wordpress.org/matala/1.1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-matala

Change History (24)

#1 @Frumph
7 years ago

needs 'new' review, not 'update' review, it hasn't formally passed the review process yet

#2 @Otto42
7 years ago

Pinging this with my username to test the trac email system.

#3 @c3mdigital
7 years ago

  • Cc m@… added

#4 @Otto42
7 years ago

  • Cc otto@… added

#5 @chipbennett
7 years ago

  • Owner set to Frumph
  • Status changed from new to assigned

Phil, this one should just need a diff review.

#6 @Frumph
7 years ago

Unfortunately as I wrote above, this never formally passed the theme review system. I will do it as a new theme later tonight since it's now assigned to me., however it will be a full review since it never had one to begin with.

#7 @chipbennett
7 years ago

Actually, I did give it a complete and thorough review. See the original ticket.

But, you won't hurt my feelings if you want to do another complete review.

#8 @Frumph
7 years ago

Well, alrightey then ;) checking the diff right now then.

#9 follow-up: @Frumph
7 years ago

  • Resolution set to not-accepted
  • Status changed from assigned to closed

=> All locations using the_content/the_excerpt - floats not clearing after is used, causing whatever below it to be maladjusted, to fix this in the containing div where the_content()/the_excerpt is used, use the class called .clear and just do a <div class="clear"></div> before the container of the div if closed like you do in the header.php, this will allow floats to clear before moving on, if a user puts a float in their posts

=> category-gallery.php -> not allowed file. http://codex.wordpress.org/Theme_Review#Theme_Template_Files Cannot predetermine if a user will have a category called gallery, try to find a different method of implementation

=> Notices:
Notice: Undefined variable: listtag in \wp-content\themes\matala\functions.php on line 176
Notice: Trying to get property of non-object in \wp-content\themes\matala\functions.php on line 191
Notice: Undefined variable: i in \wp-content\themes\matala\functions.php on line 208
Notice: Trying to get property of non-object in \wp-content\themes\matala\functions.php on line 191
Notice: Undefined index: wp-postpass_e3144369b1fdbe7030df725923dc2a51 in \wp-content\themes\matala\comments.php on line 6

  • The get property notices are very important to fix because it means your code is not passing the right data type of variable.

=> Comments are not displaying on pages, just the comment link is, clicking it goes nowhere.

/ should *not* display that the comments are off/disabled on pages

#10 in reply to: ↑ 9 ; follow-up: @Otto42
7 years ago

  • Resolution not-accepted deleted
  • Status changed from closed to reopened

Replying to Frumph:

=> All locations using the_content/the_excerpt - floats not clearing after is used, causing whatever below it to be maladjusted, to fix this in the containing div where the_content()/the_excerpt is used, use the class called .clear and just do a <div class="clear"></div> before the container of the div if closed like you do in the header.php, this will allow floats to clear before moving on, if a user puts a float in their posts

Simple enough to add, but I find it unacceptable that this is a valid basis for a theme rejection.

=> category-gallery.php -> not allowed file. http://codex.wordpress.org/Theme_Review#Theme_Template_Files Cannot predetermine if a user will have a category called gallery, try to find a different method of implementation

This is totally unacceptable, the special use of the gallery functionality is one of the primary purposes of the theme. Creating gallery pages like ma.tt's site does is one of the most requested functionalities around. The theme does this in order to a) demonstrate how and b) because it's one of the main purposes of the theme.

Gallery functionality *must* be included, and if this is cause for rejection, then the theme reviewing process is fundamentally screwed here.

#11 @Frumph
7 years ago

  • Resolution set to not-accepted
  • Status changed from reopened to closed

Gallery functionality can be done with the image.php file. What you're seeing there is category-gallery.php which means the end user must have a gallery category set, there isn't one made by default.

While you find things unacceptable the rationalization that a website ruins its looks from someone using a floated *anything* in their post and it not clearing properly is the responsibility we have to make sure that it's checked.

#12 @Otto42
7 years ago

  • Resolution not-accepted deleted
  • Status changed from closed to reopened

Sorry, but no, you are mistaken. The image.php file is for individual images, it cannot hold gallery posts.

#13 @Otto42
7 years ago

Also, there is a clearing div in all but two places for the content already. The only place it was missing was in the single.php.

#14 follow-up: @Frumph
7 years ago

  • Resolution set to not-accepted
  • Status changed from reopened to closed

I do apologize for this Otto, until it is recognized as being a valid situation, which currently it is not, this ticket is closed, not accepted.

#15 in reply to: ↑ 10 @chipbennett
7 years ago

Replying to Otto42:

Simple enough to add, but I find it unacceptable that this is a valid basis for a theme rejection.

We're discussing this in the Theme Review mail list. If you want to have a real discussion on this particular Guideline, please join in there.

But the bottom line is: if floats in the_content()/the_excerpt() aren't properly cleared, the end result could be an incorrectly rendered design. So, yes, it is important to ensure floats are cleared.

=> category-gallery.php -> not allowed file. http://codex.wordpress.org/Theme_Review#Theme_Template_Files Cannot predetermine if a user will have a category called gallery, try to find a different method of implementation

This is totally unacceptable, the special use of the gallery functionality is one of the primary purposes of the theme. Creating gallery pages like ma.tt's site does is one of the most requested functionalities around. The theme does this in order to a) demonstrate how and b) because it's one of the main purposes of the theme.

The Theme needs to include some form of documentation to inform the end user regarding how to make use of this specialized functionality. Provided that the Theme includes such documentation, I would think that the Theme's Gallery functionality falls squarely within the specialized-Theme realm.

Gallery functionality *must* be included, and if this is cause for rejection, then the theme reviewing process is fundamentally screwed here.

The process isn't "fundamentally screwed". And even if it were, a Trac ticket isn't the place to debate the matter.

#16 follow-up: @Otto42
7 years ago

And once again, frustrated by the inability of people to listen to valid argument, I find myself wanting to scrap the review process entirely.

If you're not amenable to accepting valid feedback, then this is not a review. It's a gatekeeping mechanism for keeping people out of your community.

We've had this discussion already. And I guess we'll have it again.

#17 in reply to: ↑ 14 @chipbennett
7 years ago

Replying to Frumph:

I do apologize for this Otto, until it is recognized as being a valid situation, which currently it is not, this ticket is closed, not accepted.

I think a "Gallery" Theme qualifies as a specialized use case.

That said, the Theme needs to explain how it is to be used. Whether that explanation is documented in a readme.txt, or on a Theme Options page, or contextual help, or wherever, it does need to provide such documentation.

#18 in reply to: ↑ 16 @chipbennett
7 years ago

Replying to Otto42:

And once again, frustrated by the inability of people to listen to valid argument, I find myself wanting to scrap the review process entirely.

If you're not amenable to accepting valid feedback, then this is not a review. It's a gatekeeping mechanism for keeping people out of your community.

We've had this discussion already. And I guess we'll have it again.

Take it to the Mail List, please. A Trac ticket isn't the appropriate venue for such discussion. (I do believe I can find you making the same assertion, in other Trac tickets, no?)

#19 @Otto42
7 years ago

I am taking it to the mailing list right now. This sort of behavior by the reviewers is flat out unacceptable.

#20 follow-up: @Frumph
7 years ago

"Gallery functionality *must* be included, and if this is cause for rejection, then the theme reviewing process is fundamentally screwed here."

You are not offering suggestions or 'answers' to a response why it was included, your being offensive.

NOte: Why is your behavior acceptable? Get over yourself.

#21 in reply to: ↑ 20 @Otto42
7 years ago

Replying to Frumph:

You are not offering suggestions or 'answers' to a response why it was included, your being offensive.

a) You didn't ask.

b) It's the main reason for the theme's creation in the first place. Custom gallery display functionality like this is the main question matt gets on a regular basis. It was one of the primary design goals of the theme.

NOte: Why is your behavior acceptable? Get over yourself.

Because I'm just bringing up points, not instantly rejecting your point of view without any consideration.

#22 @Frumph
7 years ago

a) I don't have to, if you want to state your argument as to why it's necessary do so without the disparaging remarks.

b) The you should have status as such and made it clear, those notes ARE seen, by the reviewer and theme admin.

"The category-gallery.php is necessary for the themes functionality."

That's really all you needed to put and it would have been acceptable.

#23 @Otto42
7 years ago

Okay, I can see how some people would read more into my strong language than was really there. I apologize. Again, I'm frustrated. That's all.

#24 @Otto42
7 years ago

Fixes made, readme added. Reference #1000.

Note: See TracTickets for help on using tickets.