WordPress.org

Make WordPress Themes

Opened 20 months ago

Closed 19 months ago

Last modified 9 months ago

#9199 closed theme (closed-newer-version-uploaded)

THEME: Twenty Twelve - 0.9

Reported by: wordpressdotorg Owned by:
Priority: major Keywords: theme-twentytwelve
Cc: cabal@…, lancewillett, emiluzelac, kovshenin

Description

Twenty Twelve - 0.9

The 2012 theme for WordPress is a fully responsive theme that looks great on any device. Features include a homepage template with a its own widgets, an optional display font, styling for post formats on both index and single views, and an optional no-sidebar page template. Make it yours with a custom menu, header image, and background.

Theme URL - http://wordpress.org/extend/themes/twentytwelve
Author URL - http://wordpress.org/

SVN - http://themes.svn.wordpress.org/twenty-twelve/0.9
ZIP - http://wordpress.org/extend/themes/download/twenty-twelve.0.9.zip?nostats=1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-twenty-twelve

https://themes.svn.wordpress.org/twenty-twelve/0.9/screenshot.png

Attachments (1)

bottom_of_font_truncated.png (24.4 KB) - added by ChantalC 20 months ago.
Truncation on bottom of text

Download all attachments as: .zip

Change History (46)

comment:1 lancewillett20 months ago

Note: This theme should *not* be pushed live after approval per core team.

Submitted so WPTRT can review and get it in Extend repo.

comment:2 follow-up: lancewillett20 months ago

Theme Check notes

WARNING: Found wrong tag, remove flexible-header from your style.css header.

ping Otto and Pross :)

See https://github.com/Pross/theme-check/pull/4 and http://core.trac.wordpress.org/changeset/21604. The Extend themes uploader check will need that extra tag added to its allowed list also.

RECOMMENDED: get_current_theme found in the file inc/theme-options.php. Deprecated since version 3.4. Use wp_get_theme() instead.
Line 153: * @uses get_current_theme() for back compat, fallback for < 3.4
Line 162: <?php $theme_name = function_exists( 'wp_get_theme' ) ? wp_get_theme() : get_current_theme(); ?>

This is an in-line back compat check that needs to be there for older versions. See notes in http://core.trac.wordpress.org/ticket/21231.

comment:3 lancewillett20 months ago

  • Cc lancewillett added

comment:4 in reply to: ↑ 2 ; follow-up: cais20 months ago

Just an observation ...

Replying to lancewillett:

RECOMMENDED: get_current_theme found in the file inc/theme-options.php. Deprecated since version 3.4. Use wp_get_theme() instead.
Line 153: * @uses get_current_theme() for back compat, fallback for < 3.4

This is an in-line back compat check that needs to be there for older versions. See notes in http://core.trac.wordpress.org/ticket/21231.

Although I don't particularly agree with the new default theme being backward compatible at all, I can accept the general discussion in the core trac ticket ... and I recognize the general user base is still widely spread over many of the 3.x versions.

comment:5 in reply to: ↑ 4 ; follow-up: kobenland20 months ago

Replying to cais:

Although I don't particularly agree with the new default theme being backward compatible at all, I can accept the general discussion in the core trac ticket ...

The IRC discussion mentioned in-ticket can be found here.

comment:6 in reply to: ↑ 5 cais20 months ago

Replying to kobenland:

The IRC discussion mentioned in-ticket can be found here.

Like I said, I accept the backward compatibility position ... besides it appears as a fait accompli at this point. My view was simply one to (force?) encourage users to update to 3.5 to use Twenty Twelve. It makes for a nicer carrot than simply being told to do so because you should.

Besides, if the end-user is not updating to 3.5 and the theme is not* being released to the repository (*yet), what difference does it make if it is backward compatible; the end-user will typically not have access to the theme in this common scenario to begin with.

Last edited 20 months ago by cais (previous) (diff)

comment:7 follow-up: kobenland20 months ago

I was trying to provide full disclosure rather than making an argument :)

comment:8 in reply to: ↑ 7 cais20 months ago

Replying to kobenland:

I was trying to provide full disclosure rather than making an argument :)

It's all good ... additional information and clarification of ideas can only improve the process.

comment:9 emiluzelac20 months ago

  • Cc emiluzelac added

comment:10 follow-up: emiluzelac20 months ago

Just curious:

In Theme Options there's Enable Web Fonts (Enable the Open Sans typeface.) at the same time "Open Sans", Helvetica, Arial, sans-serif is already being used by the Theme?

/* =Basic structure
-------------------------------------------------------------- */

/* Body, links, basics */
html {
	font-size: 87.5%;
}
body {
	font-size: 14px;
	font-size: 1rem;
	font-family: "Open Sans", Helvetica, Arial, sans-serif;
	text-rendering: optimizeLegibility;
	color: #444;
}

Thanks,
Emil

comment:11 in reply to: ↑ 10 Otto4220 months ago

Replying to emiluzelac:

In Theme Options there's Enable Web Fonts (Enable the Open Sans typeface.) at the same time "Open Sans", Helvetica, Arial, sans-serif is already being used by the Theme?

Font names that are used but not actually defined or available don't get used and the CSS falls back to the next one. So that's fine, if the Open Sans type isn't enabled, then the CSS to define it's location won't be there, and the family will fallback.

comment:12 emiluzelac20 months ago

Oh I got that Otto, what I was asking is, what's the purpose of enabling Open Sans from Theme Options, when the font is already loaded in the stylesheet, just curios that's all. I haven't seen anything behind that's why I asked. Question is not review related :)

comment:13 Otto4220 months ago

The font isn't loaded in the stylesheet, it's *referenced* in the stylesheet.

There's two parts to using a font: defining it somewhere, and referencing it elsewhere. The font-family is a reference to it. If it's not defined by turning on the option, then the reference doesn't matter. Thus, the option works.

comment:14 emiluzelac20 months ago

I see what do you mean. Got confused because Open Sans was already installed on my machine, that's why it was showing even without the link:

<link href='http://fonts.googleapis.com/css?family=Open+Sans' rel='stylesheet' type='text/css'>

Cool thanks! Awesome Theme.

ChantalC20 months ago

Truncation on bottom of text

comment:15 follow-up: ChantalC20 months ago

See above screen shot. If you disable 'overflow: hidden;' on line 1153 in style.css. It is shown okay.

(sorry didn't see where to file a ticket, so added it to this topic)

comment:16 kovshenin20 months ago

  • Cc kovshenin added

comment:17 in reply to: ↑ 15 lancewillett20 months ago

Replying to ChantalC:

See above screen shot. If you disable 'overflow: hidden;' on line 1153 in style.css. It is shown okay.

(sorry didn't see where to file a ticket, so added it to this topic)

Thanks! We're using core Trac for bug reports -- see open issues here: http://core.trac.wordpress.org/query?status=accepted&status=assigned&status=new&status=reopened&status=reviewing&component=Bundled+Theme&summary=~Twelve&col=id&col=summary&col=owner&col=type&col=status&col=priority&col=milestone&order=priority

Here's the place to make a new ticket: http://core.trac.wordpress.org/newticket

comment:18 lancewillett20 months ago

Has everyone had a chance to look and test? OK to approve?

I'm launching the theme on WordPress.com today and would be nice to point self-hosted users to Extend if they want to try it out ahead of 3.5.

comment:19 follow-up: Otto4220 months ago

Lance: What happened to "This theme should *not* be pushed live after approval"? Do we want it publicly listed or not?

comment:20 in reply to: ↑ 19 lancewillett20 months ago

Replying to Otto42:

Lance: What happened to "This theme should *not* be pushed live after approval"? Do we want it publicly listed or not?

Asking Matt and Nacin that right now.

comment:21 ChantalC20 months ago

I always thought Twenty Twelve would be released as part of 3.5.

comment:22 lancewillett20 months ago

OK, clarification. Sorry for the confusion, Otto.

Here's what the core team would like to do:

  1. Let you all on the WPTRT continue to review, then approve the theme without pushing it live so it has gone through a round of theme review. Keeping it version .9 as we find bugs and fix them.
  2. Come up with a RC version, say .9.x
  3. Nacin will handle letting the core contributor group know, via make/core site that we'd like to do a formal launch very soon
  4. Then dot the i's and cross the t's and make sure it is ready for a final WP.org release.

At that point we'll submit here a 1.0 final and that one can be pushed live.

comment:23 Otto4220 months ago

Yeah, that's what I figured. Get it reviewed normally, then do a 1.0 release with a quick diff review. Easy.

Also, featured-header has been added to the tags support.

EDIT: I mean "flexible-header", of course.

Last edited 20 months ago by Otto42 (previous) (diff)

comment:24 nacin20 months ago

I always thought Twenty Twelve would be released as part of 3.5.

Although I don't particularly agree with the new default theme being backward compatible at all, I can accept the general discussion in the core trac ticket ... and I recognize the general user base is still widely spread over many of the 3.x versions.

Besides, if the end-user is not updating to 3.5 and the theme is not* being released to the repository (*yet), what difference does it make if it is backward compatible; the end-user will typically not have access to the theme in this common scenario to begin with.

To clarify, since 3.5 is targeted for December, we decided at the start of the cycle to release Twenty Twelve 1.0 independently, well prior to 3.5, as an early holiday present. It will be the default theme in 3.5 as well but will be released while 3.4.x is the current major version.

comment:25 nhuja20 months ago

It might be how its designed but I am really confused with the interface of the theme. For example, for embedded videos and galleries, I see featured image popping up on the top. The titles are blue and theres a reply link. http://www.diigo.com/item/image/2z85f/ubpx

And then on image posts, the title is gray and small and its worse when your image post has <!--more--> tag. http://www.diigo.com/item/image/2z85f/teo5

I just feel its hard to figure out different posts. I would get rid of featured images in video/gallery posts since we are showing video/gallery (there's no point showing featured images). Plus make titles consistent and perhaps show the title on the top after the image on image post formats.

Just my 2 cents about usability. I am sure you guys have thought million times and came out with this design. :)

comment:26 nhuja20 months ago

Last edited 20 months ago by nhuja (previous) (diff)

comment:27 follow-up: Otto4220 months ago

Side note: The slug when this was uploaded became twenty-twelve. Presumably this is not desired, so before uploading the next version, hit up me or nacin to sort it out.

comment:28 in reply to: ↑ 27 lancewillett20 months ago

Replying to Otto42:

Side note: The slug when this was uploaded became twenty-twelve. Presumably this is not desired, so before uploading the next version, hit up me or nacin to sort it out.

Will do, thanks Otto. Slug should be twentytwelve with no dash.

comment:29 thomask20 months ago

There is a bug with a theme - when i turn on Enable the Open Sans typeface, all spaces in the text are replaced with !. But in the code there is still a space in a html, so there is probably some problem with the font. Testing site: http://www.seo-konzultant.cz

comment:30 thomask20 months ago

It is great that you are using rem units in CSS 3, but units like 1.714285714rem are real pain. It would be much wiser, if you would first reset all browsers to 10px default root units by html {font-size: 62.5%} and then use rem simply as equal to px, so e.g. resizable equvalent to 20px would be simply 20rem

comment:31 thomask20 months ago

I have tried to remove theme support for custom header and background:

add_action( 'after_setup_theme','remove_twentytwelve_options', 100 );
function remove_twentytwelve_options() {
remove_theme_support( 'custom-background' );
remove_theme_support( 'custom-header' );
}

and these errors appears:

Notice: Undefined index: wp-head-callback in /var/www/projects/zdrojak/htdocs/public/wp-includes/theme.php on line 1458
Notice: Undefined offset: 0 in /var/www/projects/zdrojak/htdocs/public/wp-includes/plugin.php on line 762
Notice: Undefined offset: 0 in /var/www/projects/zdrojak/htdocs/public/wp-includes/plugin.php on line 780
Notice: Undefined index: custom_background in /var/www/projects/zdrojak/htdocs/public/wp-includes/theme.php on line 1459
Notice: Undefined index: custom_image_header in /var/www/projects/zdrojak/htdocs/public/wp-includes/theme.php on line 1452

(i am testing with latest stable 3.4.2)

comment:32 follow-up: Otto4220 months ago

You removed the custom header support, but the theme is still calling things like get_header_image() and get_custom_header()->width and so on, in the header.php file. You can't remove support like that without actually removing the places that expect to have that support enabled.

comment:33 in reply to: ↑ 32 ; follow-ups: thomask19 months ago

And that's the problem of the theme (IMO) as i should have an option to remove theme support from child theme, otherwise it will such theme would be very limited and not convenient for wide spread as the main theme.

comment:34 in reply to: ↑ 33 nacin19 months ago

Replying to thomask:

And that's the problem of the theme (IMO) as i should have an option to remove theme support from child theme, otherwise it will such theme would be very limited and not convenient for wide spread as the main theme.

Please submit a ticket on http://core.trac.wordpress.org. I agree, this is lame.

comment:35 in reply to: ↑ 33 kobenland19 months ago

Opened a ticket on Core Trac to address the issue. The notices are unrelated to Twenty Twelve.

comment:36 follow-up: kovshenin19 months ago

@kobenland how about using require_if_theme_supports() in Twenty Twelve?

comment:37 in reply to: ↑ 36 kobenland19 months ago

Replying to kovshenin:

@kobenland how about using require_if_theme_supports() in Twenty Twelve?

He, that's also what I started out with yesterday :)
But I don't think this is necessary. After fixing the notices in the API, the Theme will work just fine.

comment:38 emiluzelac19 months ago

FYI

Thanks,
Emil

comment:39 follow-up: nishasingh19 months ago

Hey guys

Got one thing in theme:
No Post Title is not displaying parmalink title. "This Post has no Post Title, but must still display a link to the single-page Post view."

Thanks,
Nisha

Last edited 19 months ago by nishasingh (previous) (diff)

comment:40 in reply to: ↑ 39 ; follow-up: kobenland19 months ago

Replying to nishasingh:

No Post Title is not displaying parmalink title.

Hi Nisha, thank you for your feedback!

On posts with no title you can access the single-page view through the linked post date in the article footer. If that is not working on your install, try to change the post slug to something more meaningful than the Post ID.

Please let us know when the issue remains!

comment:41 in reply to: ↑ 40 ; follow-up: nishasingh19 months ago

Replying to kobenland:

Replying to nishasingh:

No Post Title is not displaying parmalink title.

Hi Nisha, thank you for your feedback!

On posts with no title you can access the single-page view through the linked post date in the article footer. If that is not working on your install, try to change the post slug to something more meaningful than the Post ID.

Please let us know when the issue remains!

Yes, no title post opened through the linked post date. Perfect!

Thanks kobenland

comment:42 in reply to: ↑ 41 kobenland19 months ago

Replying to nishasingh:

Yes, no title post opened through the linked post date. Perfect!
Thanks kobenland

I'm glad it worked out. Thanks for testing!

comment:43 Otto4219 months ago

  • Keywords theme-twentytwelve added; theme-twenty-twelve removed

comment:44 Otto4219 months ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from new to closed

comment:45 Ractors9 months ago

  • Priority set to major

theme not showing css validation pass

Note: See TracTickets for help on using tickets.