WordPress.org

Make WordPress Themes

Opened 20 months ago

Closed 20 months ago

Last modified 20 months ago

#9200 closed theme (live)

THEME: My Life - 0.2

Reported by: greenshady Owned by: nishasingh
Priority: Keywords: theme-my-life
Cc: justin@…

Description

My Life - 0.2

A serene blogging theme that emphasizes your content with readable typography. It uses post formats; has three nav menu locations; and supports one-, two-, and three-column layouts.

Theme URL - http://themehybrid.com/themes/my-life
Author URL - http://justintadlock.com

SVN - http://themes.svn.wordpress.org/my-life/0.2
ZIP - http://wordpress.org/extend/themes/download/my-life.0.2.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/my-life/0.1&new_path=/my-life/0.2

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-my-life&order=id

https://themes.svn.wordpress.org/my-life/0.2/screenshot.png

Change History (5)

comment:1 nishasingh20 months ago

  • Owner set to nishasingh
  • Status changed from new to accepted

comment:2 follow-up: nishasingh20 months ago

  • Resolution set to approved
  • Status changed from accepted to closed

Review Summary

  • Previous version of Theme APPROVED.
  • Previous-ticket issues addressed.
  • Theme has minor issues.
    • Image test: Wide Image, Resized In Editor title test: image is not resized in editor to 329×222. Check http://screencast.com/t/sIAedc7EEo
    • Follow CSS coding standards when authoring your CSS.
    • Theme Check result:
      1. get_bloginfo( text_direction ) was found in the file context.php. Use is_rtl() instead.
      2. TEMPLATEPATH was found in the file core.php. Use get_template_directory() instead.
        Line 195: $hybrid->theme_data = get_theme_data( trailingslashit( TEMPLATEPATH ). 'style.css' );
        
      3. STYLESHEETPATH was found in the file core.php. Use get_stylesheet_directory() instead.
        Line 206: $hybrid->child_theme_data = get_theme_data( trailingslashit( STYLESHEETPATH ). 'style.css' );
        
  • Please address required issues in next Theme revision.
  • Ticket being resolved as APPROVED.

comment:3 in reply to: ↑ 2 ; follow-up: greenshady20 months ago

Just to make this clear: Next reviewer, the only required issue stated in this ticket is the following.

This wasn't made clear in the review.

  • Follow CSS coding standards when authoring your CSS.

That's a bit vague. If you have some specific recommendations, please state them clearly and I'll take them under advisement.

  1. get_bloginfo( text_direction ) was found in the file context.php. Use is_rtl() instead.

These two functions are not interchangeable.

comment:4 in reply to: ↑ 3 ; follow-up: nishasingh20 months ago

Replying to greenshady:

Just to make this clear: Next reviewer, the only required issue stated in this ticket is the following.

This wasn't made clear in the review.

Image test: WIDE IMAGE, RESIZED IN EDITOR, Image is 900x598px, resized in editor to 329×222 : Wide image (900x598px) is not resize in editor to 329×222. Check page3 title

  • Follow CSS coding standards when authoring your CSS.

That's a bit vague. If you have some specific recommendations, please state them clearly and I'll take them under advisement.

I am talking about css structure (Use tabs, not spaces, to indent each property.).

  1. get_bloginfo( text_direction ) was found in the file context.php. Use is_rtl() instead.

These two functions are not interchangeable.

comment:5 in reply to: ↑ 4 greenshady20 months ago

  • Follow CSS coding standards when authoring your CSS.

That's a bit vague. If you have some specific recommendations, please state them clearly and I'll take them under advisement.

I am talking about css structure (Use tabs, not spaces, to indent each property.).

I do use tabs for indenting. Nevertheless, that's really outside the scope of the theme review process.

Note: See TracTickets for help on using tickets.