WordPress.org

Make WordPress Themes

#9227 closed theme (closed-newer-version-uploaded)

THEME: StartupWP - 0.3

Reported by: StartupWP Owned by: garinungkadol
Priority: Keywords: theme-startupwp
Cc: contact@…

Description

StartupWP - 0.3

A startup WordPress theme for anyone looking to build their first website with ease and power. This theme is HTML5, responsive and includes features such as custom logo, background, colors, social profile icons and more.

Theme URL -
Author URL - http://startupwp.com/

SVN - http://themes.svn.wordpress.org/startupwp/0.3
ZIP - http://wordpress.org/extend/themes/download/startupwp.0.3.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/startupwp/0.2&new_path=/startupwp/0.3

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-startupwp&order=id

https://themes.svn.wordpress.org/startupwp/0.3/screenshot.png

Change History (12)

comment:1 startupwp20 months ago

I've conformed to the repo guidelines as much as possible, respectively. If exceptions cannot be made for some of the unique features of the theme, unfortunately I'll simply have to remove them diminishing the value and use to users.

I ask that the assigned reviewer please neither approve or disapprove the theme until all ducks are in a row with further discussion.

Thank You

comment:2 garinungkadol20 months ago

  • Owner set to garinungkadol
  • Status changed from new to assigned

comment:3 garinungkadol20 months ago

@StartupWP: are there any other methods out there for you to include the functionality without having inline scripts?

comment:4 follow-up: startupwp20 months ago

The thing is it's time to get the 1.0 out there, this can't be put off any longer. Right now, my top concerns are meeting the requirements, though I will naturally refine and improve the theme over and over moving forward no doubt.

As far the inline scripts issue here's what I'm hearing:

"The Guidelines do NOT prohibit either inline styles or inline scripts; rather, they merely prohibit hard-coding script and stylesheet *links* in the document head. Technically speaking, though; you *could* put the script in a separate file, and fire wp_enqueue_script() inline. It's just not *required* to do so."

So right now, it's time to get the theme approved and published.

Can you please do me a favor and approve this version, but not let it get pushed. I can then upload it as the proper 1.0 for first release.

Thanks

comment:5 in reply to: ↑ 4 garinungkadol20 months ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

Issues from Previous Review #8878

  • NOT-FIXED: Theme is using the text-domain 'startup' instead of 'startupwp'. There is a conflict because there is a pre-existing theme 'startup'. As you are also the owner of that theme, if you want to use the text-domain 'startup' you will have to upload the theme there. Otherwise you must change the textdomain to 'startupwp'.
  • FIXED: Lists are styled appropriately when used in comments
  • FIXED: Page Templates "Sidebar Two Left" and "Sidebar Two Right" display content properly.
  • FIXED: Header font option is saved
  • FIXED: Script handles are unique
  • NOT-REQUIRED-TO-BE-FIXED: Inline scripts are allowed in template files.
  • Recommendation: Not-approved

comment:6 startupwp20 months ago

  • NOT-FIXED: Theme is using the text-domain 'startup' instead of 'startupwp'. There is a conflict because there is a pre-existing theme 'startup'. As you are also the owner of that theme, if you want to use the text-domain 'startup' you will have to upload the theme there. Otherwise you must change the textdomain to 'startupwp'.

I do appreciate you taking the time. However, I would like to get a second opinion on this and to be reassigned to a new reviewer please.

I understand the point of this guideline, but my case would be an exception to the rule as there is not a possible conflict to occur as detailed explicitly here:

http://themes.trac.wordpress.org/ticket/8878#comment:12 - bullet point 2

This isn't an arbitrary request, this is to stay consistent with the pro version of theme ensuring that if and when a user upgrades, that that transition is as smooth as possible.

There is no possible harm to be made by allowing this exception and only issues to arise from doing what you're asking.

In theory there is a conflict, if the original Startup was ever to be completed, but that is not the case so factually, there is no conflict.

I think guidelines/rules are wonderful, but for the greater good of progress and usability they should be appending and/or have exceptions made sometimes. This is clearly one of those cases.

Thanks

comment:7 follow-up: chipbennett20 months ago

I agree that startup is close enough to startupwp, and should be appropriate as the Theme textdomain.

The intent of this guideline is to ensure that the Theme textdomain has as little chance as possible to clash with another defined textdomain (i.e. from a Plugin). The idea is to avoid acronyms, abbreviations, or arbitrary terms as Theme textdomains, *not* to require an exact-match between theme-slug and textdomain.

And even if the textdomain were something not appropriate, I would mark it as "required, but can be resolved in the next Theme revision."

I would recommend resolving as approved, if textdomain is the only outstanding issue.

comment:8 in reply to: ↑ 7 garinungkadol20 months ago

Replying to chipbennett:

I agree that startup is close enough to startupwp, and should be appropriate as the Theme textdomain.

The intent of this guideline is to ensure that the Theme textdomain has as little chance as possible to clash with another defined textdomain (i.e. from a Plugin). The idea is to avoid acronyms, abbreviations, or arbitrary terms as Theme textdomains, *not* to require an exact-match between theme-slug and textdomain.

And even if the textdomain were something not appropriate, I would mark it as "required, but can be resolved in the next Theme revision."

I would recommend resolving as approved, if textdomain is the only outstanding issue.

So text domains fall under the same purview as prefixes - as long as it is something that doesn't clash with a plugin then it's acceptable?
Thanks for the clarification because the way it was written in the codex implied you had to use the theme's slug as the text-domain.

@StartupWP consider your theme approved.

comment:9 chipbennett20 months ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

comment:10 chipbennett20 months ago

Since the proposed resolution is now approved, go ahead and upload the 1.0 version, and link the ticket here. We'll close this one as newer-version-uploaded, and approve the new ticket.

comment:11 startupwp20 months ago

1.0 uploaded here:

http://themes.trac.wordpress.org/ticket/9252

Thank you very much garinungkadol and chipbennett for working so diligently in helping me to finally get all issues resolved and this theme going.

comment:12 chipbennett20 months ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.