WordPress.org

Make WordPress Themes

Opened 20 months ago

Closed 19 months ago

Last modified 19 months ago

#9318 closed theme (not-approved)

THEME: Childishly Simple - 1.002

Reported by: richarduk Owned by: bhadaway
Priority: Keywords: theme-childishly-simple
Cc: richard@…

Description

Childishly Simple - 1.002

The colors of almost everything can be changed from within the options page. An image can be uploaded across the top of the website. This is a multiple-layout theme - choose between one-column, two-column-content-left, two-column-content-right, three-column-content-left, three-column-content-middle and three-column-content-right. All layouts are fixed or flexible width and can be whatever width you want. Sidebar widths can be changed. The sidebars and footer contain multiple items and endless widget areas that can be turned on or off. Includes featured images, top and bottom dropdown CSS menus, post formats (e.g. asides), comment bubbles and style sheets for print and admin. The options page is one long page with idiot-proof pictures of what every option does.

Theme URL - http://www.alchemweb.co.uk/wordpress-childishlysimple-theme/
Author URL - http://www.alchemweb.co.uk

SVN - http://themes.svn.wordpress.org/childishly-simple/1.002
ZIP - http://wordpress.org/extend/themes/download/childishly-simple.1.002.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/childishly-simple/1.001&new_path=/childishly-simple/1.002

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-childishly-simple&order=id

https://themes.svn.wordpress.org/childishly-simple/1.002/screenshot.png

Change History (5)

comment:1 bhadaway19 months ago

  • Owner set to bhadaway
  • Status changed from new to assigned

comment:2 bhadaway19 months ago

  • Resolution set to not-approved
  • Status changed from assigned to closed
  • I don't believe this will be acceptable in the repo:

"YOU NEED TO CLICK ON THE CHILDISHLY SIMPLE OPTIONS BUTTON IN ADMIN / APPEARANCE TO ACTIVATE THIS THEME"

Where there's not a site title or navigation out-of-the-box.

Before uploading a new version can you please clarify the purpose of this methodology? Again, this most likely will not be allowed unless there's a very good reason for this.

  • No single post navigation to browse from one post to the other.
  • Squished big image:

http://bryanhadaway.com/testing/theme-reviews/childish/1.png

img.size-full {
  border: 0 none;
  height: auto;
  max-width: 100%;
  padding: 0;
  width: auto;
}

Adding height: auto should fix.

  • No fallback title for when the header is left empty.

http://bryanhadaway.com/testing/theme-reviews/childish/2.png

You can add:

add_filter('the_title', 'childishlysimple_title');
function childishlysimple_title($title) {
if ($title == '') {
return 'Untitled';
} else {
return $title;
}
}

to functions.php.

  • Footer not sticking to bottom.

http://bryanhadaway.com/testing/theme-reviews/childish/3.png

comment:3 richarduk19 months ago

Thanks bhadaway

I've sorted out most of the issues - I'll remove the 'Click here to activate stuff', I didn't realise it was meant to work straight out of the box. I might have had an issue with widgets 'cos my theme activates them from within the options page, but never mind, sorted.

Single post navigation - my bad, I accidentally commented out the code, probably when testing.

Thanks for the code for the default title on posts.

Footer not sticking to bottom - not been able to replicate this, was an issue with last submission. Do you have a full screenshot, or css, or HTML? What browser did you use? I've tried all the major browsers. Does it only happen with default setting once theme is activated?

many thanks.

comment:4 richarduk19 months ago

Before I forget:

img.size-full{
border:0;
height:auto !important;
margin:0;
max-width:100%;
padding:0;
position:relative;
}

Worked fine in chrome, FF, safari, opera, and also resized the smaller image above it correctly - but doesn't work in IE 8. Width:inherited makes everything go pear-shaped.

However, version 1.4 of twenty eleven has failed to style size-full correctly as well, getting identically sized images for the resized and unresized images in both IE and FF, so I don't think anyone's solved this yet. But happy to be proved wrong.

comment:5 bhadaway19 months ago

Footer - I'm on Mac / Firefox (always up-to-date). Are you using position: absolute on your footer? That could be a problem. Try adding clear: both to it. According to the screenshot you can see that widgets were activated (I don't recall if it was an issue when they weren't).

Images - But do they work in IE9? I think we can only reasonably expect that your theme works properly in all the latest major browser versions.

I personally use (for all images):

img{max-width:100% !important;height:auto}

Good luck.

Note: See TracTickets for help on using tickets.