WordPress.org

Make WordPress Themes

Attachments (5)

center-image.jpg (36.7 KB) - added by garinungkadol 19 months ago.
center-image-caption.jpg (50.6 KB) - added by garinungkadol 19 months ago.
child-links.jpg (13.9 KB) - added by garinungkadol 19 months ago.
clearing-floats.jpg (32.2 KB) - added by garinungkadol 19 months ago.
wide-images-resized.jpg (57.5 KB) - added by garinungkadol 19 months ago.

Download all attachments as: .zip

Change History (10)

comment:1 garinungkadol19 months ago

  • Owner set to garinungkadol
  • Status changed from new to assigned

garinungkadol19 months ago

garinungkadol19 months ago

comment:2 garinungkadol19 months ago

Issues from Previous Review

  • NOT-FIXED: Floated elements must be properly cleared. See clearing-floats.jpg
  • FIXED: Translation function added for identified text. However see below for more text that you have missed.

Theme Unit Tests

Index / Archive Views

  • REQUIRED: The "Continue" link should go to the single post at "More" tag location.
  • REQUIRED: Images with center-alignment (with and without captions) are not displayed in the center. See center-image.jpg and center-image-caption.jpg

Single Post View

Navigation Menu

  • REQUIRED: Check the styling of child links in the Navigation Menu. Long text is not contained within the box. See child-links.jpg. If this cannot be fixed, please note this in the readme.txt

Functionality

  • REQUIRED: You have only included wp_nav_menu() for the primary menu. The "Footer Navigation Menu" has not been included. I can set a menu in Appearance >> Menu but I cannot see it on the site.
  • REQUIRED: I can set content for the "sidebar" widget but I can't see it displayed anywhere on the site. In what instance can this sidebar be seen?

Code Quality

  • REQUIRED: Make sure that text have the appropriate translation function:

Line 27, 28, Line 39, comments.php
Line 15, loop-footer.php
Line 19, loop-header.php

  • REQUIRED: Additional scripts should not be hard-coded in the header template. The most appropriate way to handle the following is to place it in a function that hooks into wp_head.
    <!--[if lt IE 9]>
    <script src="<?php echo THEME_JS_URI; ?>html5shiv.js" type="text/javascript"></script>
    <![endif]-->
    

Recommendation: NOT-APPROVED

comment:3 follow-up: c3mdigital19 months ago

Hi garinungkadol,

Thank you for taking the time to do this review and for being so thorough! I have an updated version I can upload tomorrow. Can you keep this open till then? Thanks again.

comment:4 in reply to: ↑ 3 garinungkadol19 months ago

Replying to c3mdigital:

Thank you for taking the time to do this review and for being so thorough! I have an updated version I can upload tomorrow. Can you keep this open till then? Thanks again.


Sure. Just post the link to the new ticket here and I'll continue the review there.

comment:5 garinungkadol18 months ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

It's been 10 days since your last comment so I'm going to close this ticket.

When you've re-submitted your theme, leave the link here so I will check the changes and if everything is okay approve your theme.

Thanks
~ Vicky

Note: See TracTickets for help on using tickets.