WordPress.org

Make WordPress Themes

#9835 closed theme (not-approved)

THEME: Noteworthy - 1.0

Reported by: wpthemesnz Owned by: Sanjiv Saha
Priority: Keywords: theme-noteworthy
Cc: charles@…

Description

Noteworthy - 1.0

Noteworthy is a theme that is proudly inspired by USAToday.com. Perfect for news or magazine style blogs and even photo galleries. The theme features social media buttons which are easily set up through a theme options page in the admin.

Theme URL - http://wpthemes.co.nz/
Author URL - http://wpthemes.co.nz/noteworthy/

SVN - http://themes.svn.wordpress.org/noteworthy/1.0
ZIP - http://wordpress.org/extend/themes/download/noteworthy.1.0.zip?nostats=1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-noteworthy

https://themes.svn.wordpress.org/noteworthy/1.0/screenshot.png

Change History (3)

comment:1 emiluzelac17 months ago

  • Owner set to Sanjiv Saha
  • Status changed from new to assigned

comment:2 Sanjiv Saha17 months ago

Theme Check Plugin: Pass
Deprecated Notices Plugin: Pass
Theme Unit Test Data: Pass
Debogger Plugin: 1 error (listed below)

Required

  • Use get_stylesheet_uri() to load the style.css file not get_template_directory_uri(). Refer to twentytwelve theme if you want to load the style.css file with the wp_enqueue_style() function.
  • In sidebar.php file, $social_optionsfacebook?, $social_optionstwitter? and other varaibles of the other social links give this error in WP_DEBUG set to true mode. Also shown by the debogger plugin.
    • Error: Uninitialized string offset: 0 in C:\wamp\www\themereview\wp-content\themes\noteworthy\sidebar.php on line 12. And in other lines for other social links.
    • Note: You need to initialize the value for this array variables. You can set them to blank as initialization to avoid these errors.
  • Settings page capability in add_theme_page() function should be edit_theme_options rather than administrator.
  • do_action( 'before' ) and do_action( 'before_sidebar' ) used in header.php and sidebar.php respectively but there is no action avaliable in WordPress called 'before' and 'before_sidebar'. I guess these are the theme's custom ones so, prefix it with "theme-slug".
  • In your functions.php file, in the noteworthy_main_nav() function you have following code.
wp_nav_menu( 
    	array( 
    		'menu' => 'primary', /* menu name */
    		'theme_location' => 'primary', /* where in the theme it's assigned */
    		'container_class' => 'menu', /* container class */
    		'fallback_cb' => 'noteworthy_main_nav_fallback' /* menu fallback */
    	)
    );
  • Note: You should set 'menu' key to blank. If you set 'menu' to 'primary', the user should always create menu name 'primary' to use to custom menu, that he/she might not know. If he/she creates a menu with other name say 'secondary' then he/she cannot use that menu. So, either inform the user to name the menu name as 'primary' or leave the key value blank( this one recommended ).

Suggestions

  • Add supported browsers list into readme.txt.
  • Hightlight the selected and hovered menu with some css.
  • Some traslatable text still to be process with translation functions. It's hard to find all the text and process them, but you could always process the left over text messages with translation functions in the updates :). I saw some not processed messages in sidebar.php file.
  • Comment the files. I have seen you haven't commented any of the files.( header.php, index.php and others). Refer to twentytwelve theme.

comment:3 emiluzelac17 months ago

  • Resolution set to not-approved
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.