WordPress.org

Make WordPress Themes

#9838 closed theme (closed-newer-version-uploaded)

THEME: D5 Design - 1.0

Reported by: d5creation Owned by: Sanjiv Saha
Priority: Keywords: theme-d5-design
Cc: support@…

Description

D5 Design - 1.0

Design is CSS3 Powered super elegant and Professional Responsive Theme. Design is for Smart Companies and Persons who love to innovate. Customizable Background and Them Options will give the WordPress Driven Site an attractive look. Right and Footer Sidebar will be usable for showing the widgets. Full Wide page can be used for showing showcase or other pages. Pro version of Design Theme has more than 100 Options which will give you the opportunity to customize almost all the features of this Theme with extra functionality. A demo of Design Theme can be found here: http://demo.d5creation.com/wp/themes/design.

Theme URL - http://d5creation.com/theme/design/
Author URL - http://d5creation.com/

SVN - http://themes.svn.wordpress.org/d5-design/1.0
ZIP - http://wordpress.org/extend/themes/download/d5-design.1.0.zip?nostats=1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-d5-design

https://themes.svn.wordpress.org/d5-design/1.0/screenshot.png

Attachments (1)

menuproblem.PNG (83.0 KB) - added by Sanjiv Saha 17 months ago.
Many menu items problem

Download all attachments as: .zip

Change History (9)

comment:1 emiluzelac17 months ago

  • Owner set to rachelbaker
  • Status changed from new to assigned

comment:2 emiluzelac17 months ago

  • Owner changed from rachelbaker to Sanjiv Saha

Sorry, wrong assignment :)

Sanjiv Saha17 months ago

Many menu items problem

comment:3 Sanjiv Saha17 months ago

Theme Check Plugin: Pass
Deprecated Notices Plugin: Pass
Theme Unit Test Data: Pass
Debogger Plugin: Pass

Required

  • If we search for something in search box. The theme breaks with this following error. Fix the search.php file.
    • Error: Parse error: syntax error, unexpected T_ELSE in C:\wamp\www\themereview\wp-content\themes\d5-design\search.php on line 37.
  • If there are many menu items, some of the menu items overlap with the belower design. I have attached an image named menuproblem.png to clearyly show the problem. See and fix it.
  • Theme Namespacing: Themes are required to use a unique slug as a prefix for anything in the public namespace, including all custom function names, classes, hooks, public/global variables, database entries (Theme options, post custom metadata, etc.)
    • Custom Functions
      • Some are named like design_excerpt_length( this type of naming with design as prefix are okay), some are named like optionsframework_load_sanitization( not okay ), some are named like of_get_option( not okay ). You need to have unique slug( recommended theme-slug as unique slug like 'desigh' is okay), those custom functions in options framework plugin copied files also need to have unique slug name.
    • Database entries
      • option name optionframework not okay( need to have unique slug as prefix )
      • Option name design is okay( but design_options/design_theme_options type would be better )
      • post custom metadata's name sbss not okay( make it like design-ss )
    • Custom Hooks
      • Hook name optionsframework_custom_scripts not okay( make it like design_custom_scripts )
    • Global Contants
      • Constant name used OPTIONS_FRAMEWORK_DIRECTORY is not okay( make it like DESIGN_DIRECTORY )
  • If we use a custom image in header and then again if we click on Restore Original Header Image then it outputs following notice in wp debug true mode. Have a look at this as well.
    • Notice: Undefined variable: default_data in C:\wamp\www\themereview\wp-admin\custom-header.php on line 1050
  • Changing the background color/background image does not reflect in the footer part. It is reflected only in the content and header part(not footer). Reflect it in the footer part as well, or give information about it somewhere like in readme.txt files that the change will not reflect in the footer part.
  • For checkboxes and select options, Themes are required to use the checked() and selected() functions for outputting checked="checked" and selected="selected", respectively.
    • The theme has not used these functions in options-interface.php file.
  • I see the following code in files like index.php, blog.php and others as well.
    <div class="alignleft"><?php previous_posts_link('&laquo; Previous Entries') ?></div>
    <div class="alignright"><?php next_posts_link('Next Entries &raquo;','') ?></div>
    

Confusion

  • I would like to ask the admin on this. A part in description in style.css file says Pro version of Design Theme has more than 100 Options which will give you the opportunity to customize almost all the features of this Theme with extra functionality. Is it okay? In my opinion, yes we can promote about the pro versions as well, but not in description of style.css file( describing the theme only would be better )

Suggestion

  • Add supported browsers list into readme.txt file.
  • ;(colon) is missing in this following code after the wp_title() function call.
    <title><?php wp_title() ?></title>
    
  • I see the following code in many files such as index.php, archive.php and many others.
    <div class="pagenev"><div class="conwidth"><?php design_breadcrumbs() ?></div></div>
    
    • The function defination for design_breadcrumbs is empty so just remove the function call also. ( I don't see any use of it )
  • In the single view of every post, just below the post the theme gives next post's and previous's post link, but I don't like the idea for the next and previous image link. Whenever I view those image, I get kind of lost, I don't like it and recommend to remove it( just my opinion )
  • Please indent the code in the files properly. You can follow coding standards at http://codex.wordpress.org/WordPress_Coding_Standards

comment:4 d5creation17 months ago

Hello Sanjiv,
Thank you for your in-depth review. But we think that all of these are not required. We used a options framework which is being used with many themes. Is it necessary to use unique slug for that framework? We think no.

Waiting for Emil for his opinion.

comment:5 Sanjiv Saha17 months ago

Hi d5creation,

I have reviewed your theme against http://codex.wordpress.org/Theme_Review.

The others points(except themenamespacing) that I have marked as required, you surely need to fix them.

In the case of themenamespacing, the theme review guidelines of codex says Themes are required to use a unique slug as a prefix for anything in the public namespace, including all custom function names, classes, hooks, public/global variables, database entries (Theme options, post custom metadata, etc.)
So, for the name of database entries, hooks, functions names you need to prefix them with unique-slug name. I see others reviewer are also asking for the same.
But I see that you are using the framework for creating the theme options, so I don't know what the admin have to say about it? Whether allowable or not?

Let's wait for the opinion of Emil on this as well.

Regards,
Sanjiv

comment:6 d5creation17 months ago

Hello Sanjiv,

Based on our previous experience and thinking we consider the first one is required but we are confusing about the rest of the points.

Yes, let's wait until the suggestions of Emil.

comment:8 emiluzelac17 months ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.