WordPress.org
Get WordPress

Make WordPress Themes

Opened 4 months ago

Closed 3 months ago

#280594 closed theme (not-approved)

THEME: KMD Docs – 1.0.0

Reported by: kwesimooredigital Owned by: dimikjones
Priority: new theme Keywords: theme-kmd-docs
Cc: emmanueloti955@…

Description

KMD Docs - 1.0.0

A three-column documentation theme — sidebar navigation, an auto-generated on-page table of contents, instant search, dark mode, and full Customizer branding. Built entirely on core WordPress Pages (no custom post type, no required plugin): assign the “Documentation Section” template to a Page and nest more Pages underneath it to build your sidebar.

Theme URL - ​https://kwesimoredigital.com/kmd-docs
Author URL - ​https://kwesimoredigital.com

Trac Browser - https://themes.trac.wordpress.org/browser/kmd-docs/1.0.0
WordPress.org - ​https://wordpress.org/themes/kmd-docs/

SVN - ​https://themes.svn.wordpress.org/kmd-docs/1.0.0
ZIP - ​https://downloads.wordpress.org/theme/kmd-docs.1.0.0.zip?nostats=1
Live preview – ​https://playground.wordpress.net/#…

History:

Ticket Summary Status Resolution Owner
#280594 THEME: KMD Docs – 1.0.0 closed not-approved dimikjones

(this ticket)


https://themes.svn.wordpress.org/kmd-docs/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
  • RECOMMENDED: No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
  • RECOMMENDED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • RECOMMENDED: Could not find the comment-reply script enqueued.
  • RECOMMENDED: Could not find comments_template. See: ​comments_template 
     <?php comments_template( $file, $separate_comments ); ?>
  • RECOMMENDED: Could not find wp_list_comments. See: ​wp_list_comments 
     <?php wp_list_comments( $args ); ?>
  • RECOMMENDED: Could not find comment_form. See: ​comment_form 
     <?php comment_form(); ?>
  • WARNING: Could not find a copyright notice for the theme. A copyright notice is needed if your theme is licenced as GPL. <a href="​https://www.gnu.org/licenses/gpl-howto.html" target="_blank">Learn how to add a copyright notice (opens in a new window).</a>
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • RECOMMENDED The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED .sticky css class is recommended in your theme css.
  • RECOMMENDED .bypostauthor css class is recommended in your theme css.
  • RECOMMENDED .alignleft css class is recommended in your theme css.
  • RECOMMENDED .alignright css class is recommended in your theme css.
  • RECOMMENDED .aligncenter css class is recommended in your theme css.
  • RECOMMENDED .wp-caption css class is recommended in your theme css.
  • RECOMMENDED .wp-caption-text css class is recommended in your theme css.
  • RECOMMENDED .gallery-caption css class is recommended in your theme css.
  • RECOMMENDED This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_theme_support( "responsive-embeds" ) was found in the theme. It is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_theme_support( "wp-block-styles" ) was found in the theme. It is recommended that the theme implement this functionality.
  • RECOMMENDED This theme contains no sidebars/widget areas. See ​Widgets API

Change History (3)

This ticket was mentioned in ​Slack in #themes by dimikjones. ​View the logs.
3 months ago

#2 @bijayyadav
3 months ago

  • Owner set to dimikjones
  • Status new → reviewing

#3 @dimikjones
3 months ago

  • Resolution → not-approved
  • Status reviewing → closed

Hi @kwesimoredigital,

Thank you for submitting KMD Docs. I have reviewed your theme against the WordPress.org Theme Review requirements.

At this point, the theme does not fully meet the requirements and cannot be approved. Please review the requirements carefully, fix the issues listed below, and upload a new version for review.

The Theme Review Team does not hard reject themes - we want you to resubmit your theme. However, when a ticket is closed as not approved, it loses its position in the review queue. When you submit an update, a new ticket will be created at the end of the queue.

You can check all the requirements here ​https://make.wordpress.org/themes/handbook/review/required/

Use this upload form to submit your update: ​​​​​https://wordpress.org/themes/upload/

Required

1. Missing Copyright Notice

File: readme.txt

The theme does not include a copyright notice for the theme itself. A copyright notice is required for themes licensed under the GPL to the readme.txt file. Reference: ​https://make.wordpress.org/themes/handbook/review/required/#1-licensing-copyright

2. Missing languages Folder

File: functions.php, line 24

The theme calls load_theme_textdomain( 'kmd-docs', KMDDOCS_DIR . '/languages' ); but the languages folder does not exist. Please create an empty languages folder at the theme root, and include a .pot file for translators. Reference: ​https://developer.wordpress.org/apis/internationalization/localization/

3. Duplicate Script Enqueue - customizer-preview.js

File: inc/customizer.php, lines 230–239 and inc/enqueue.php, lines 70–77

The kmddocs-customizer-preview script is enqueued in both files. Both hooks fire inside the Customizer preview, causing the script to load twice. Double check this and remove one of the enqueue calls if confirmed.

4. Missing Pagination on Search Results and index.php

File: search.php
File: index.php

These templates do not include pagination links. If more than the default number of posts per page match the query, users will have no way to navigate to additional results. Please add the_posts_navigation() or paginate_links() after the loop.

5. Registered Navigation Menu Never Rendered - Dead Code

File: functions.php, lines 44–48

register_nav_menus(
	array(
		'footer' => __( 'Footer Links', 'kmd-docs' ),
	)
);

The theme registers a 'footer' navigation menu location, but wp_nav_menu() is never called anywhere in the theme. This means users can assign a menu to the location, but it will never appear on the front end. Either add wp_nav_menu( array( 'theme_location' => 'footer' ) ) to the footer, or remove the unused register_nav_menus() call.

6. Styling issues

Although we are not reviewing theme styling, obvious styling issues needs to be fixed e.g.
​https://prnt.sc/hVBVMPMkg3Y7
​https://prnt.sc/zQSmXdGpVywu
+ possibly more

I warmly suggest to import theme unit test data and go trough some posts/pages and fix any inconsistencies of this kind.

7. Inline Styles in Admin Page

File: inc/admin-page.php

Multiple inline style attributes are used on the admin page. Consider moving these to a separate admin stylesheet enqueued via admin_enqueue_scripts so styles cannot leak out to other admin screens. Reference: ​https://developer.wordpress.org/reference/hooks/admin_enqueue_scripts/

8. Utility CSS Classes Not Prefixed

File: assets/css/*.css, header.php, template-parts/sidebar.php

Utility classes like u-flex, u-hide, u-hide-mobile, u-text-muted are not prefixed with the theme slug. Please consider prefixing them with kmddocs- to avoid potential collisions with some plugins. Reference: ​https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/

File: header.php, lines 40–47

.header-brand-mobile is a plain <div> rather than an <a> tag, so mobile users cannot tap the brand to return to the documentation home. Please consider making it a link consistent with the desktop version.

10 Missing Upgrade Notice Section

File: readme.txt

The readme.txt file is missing the == Upgrade Notice == section. While not strictly required by the handbook, adding this section is a good practice to inform users about important updates.

Once these issues are addressed, please upload a new version, and I will be happy to take another look. I look forward to your updated submission!

Note: See TracTickets for help on using tickets.