Make WordPress Themes

Opened 4 weeks ago

Closed 7 days ago

#295259 closed theme (live)

THEME: Al Qamara Lite – 1.0.5

Reported by: alqamara Owned by: bijayyadav
Priority: previously reviewed Keywords: theme-al-qamara-lite
Cc: rejaul248@…

Description

Al Qamara Lite - 1.0.4

A clean, fast theme for blogs, business sites and WooCommerce stores. Built on Bootstrap 5, with a mobile slide-in menu, a widget-driven homepage, a Customizer-based header, footer and colour options, and full WooCommerce styling.

Theme URL -
Author URL - ​https://profiles.wordpress.org/alqamara/

Trac Browser - https://themes.trac.wordpress.org/browser/al-qamara-lite/1.0.4
WordPress.org - ​https://wordpress.org/themes/al-qamara-lite/

SVN - ​https://themes.svn.wordpress.org/al-qamara-lite/1.0.4
ZIP - ​https://downloads.wordpress.org/theme/al-qamara-lite.1.0.4.zip?nostats=1
Live preview – ​https://playground.wordpress.net/#…

Diff with previous version: [353543] https://themes.trac.wordpress.org/changeset?old_path=al-qamara-lite/1.0.3&new_path=al-qamara-lite/1.0.4

History:

Ticket Summary Status Resolution Owner
#293518 THEME: Al Qamara Lite – 1.0.3 closed not-approved bikram_sth
#295259 THEME: Al Qamara Lite – 1.0.5 closed live bijayyadav

(this ticket)

#298283 THEME: Al Qamara Lite – 1.0.6 closed live themetracbot
#298528 THEME: Al Qamara Lite – 1.0.7 closed live themetracbot


https://themes.svn.wordpress.org/al-qamara-lite/1.0.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
  • RECOMMENDED: No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "align-wide" ) was found in the theme. It is recommended that the theme implement this functionality.

Change History (5)

#1 @bijayyadav
10 days ago

  • Owner set to bijayyadav
  • Status new → reviewing

#2 @bijayyadav
7 days ago

Hi @alqamara

  • ​Keyboard navigation - not ok
    • Some resources to help you:
    • Issues with your theme:
      • In the mobile menu, focus should be trapped inside the modal. Once you tab past the last menu item, the focus should go on the close button. Once you shift+tab on the first element focus should go on the close button (and if you shift tab on this, it should focus the last element in the menu).
  • When minified scripts or files are used, the original files must also be included in the theme folder.
  • The wp_enqueue_script & wp_enqueue_style handles should not be prefixed if they are 3rd-party assets, like a framework’s CSS files or any 3rd-party script.

Thank you

#3 @themetracbot
7 days ago

  • Summary THEME: Al Qamara Lite – 1.0.4 → THEME: Al Qamara Lite – 1.0.5

Al Qamara Lite - 1.0.5

A clean, fast theme for blogs, business sites and WooCommerce stores. Built on Bootstrap 5, with a mobile slide-in menu, a widget-driven homepage, a Customizer-based header, footer and colour options, and full WooCommerce styling.

Theme URL -
Author URL - ​https://profiles.wordpress.org/alqamara/

Trac Browser - https://themes.trac.wordpress.org/browser/al-qamara-lite/1.0.5
WordPress.org - ​https://wordpress.org/themes/al-qamara-lite/

SVN - ​https://themes.svn.wordpress.org/al-qamara-lite/1.0.5
ZIP - ​https://downloads.wordpress.org/theme/al-qamara-lite.1.0.5.zip?nostats=1
Live preview – ​https://playground.wordpress.net/#…

Diff with previous version: [356594] https://themes.trac.wordpress.org/changeset?old_path=al-qamara-lite/1.0.4&new_path=al-qamara-lite/1.0.5

History:

Ticket Summary Status Resolution Owner
#293518 THEME: Al Qamara Lite – 1.0.3 closed not-approved bikram_sth
#295259 THEME: Al Qamara Lite – 1.0.5 closed live bijayyadav

(this ticket)

#298283 THEME: Al Qamara Lite – 1.0.6 closed live themetracbot
#298528 THEME: Al Qamara Lite – 1.0.7 closed live themetracbot


https://themes.svn.wordpress.org/al-qamara-lite/1.0.5/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
  • RECOMMENDED: No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "align-wide" ) was found in the theme. It is recommended that the theme implement this functionality.

#4 @alqamara
7 days ago

Hi @bijayyadav,

Thank you very much for taking the time to review Al Qamara Lite so carefully, and for the clear explanation and the helpful resources — the TwentyTwenty example made it easy to see exactly how the keyboard navigation should work. I really appreciate your guidance.

Version 1.0.5 is now uploaded and addresses all three points:

  1. Keyboard navigation: while the mobile menu is open, focus stays inside it. Tab past the last menu item moves focus to the close button; Shift+Tab on the first element moves to the close button, and Shift+Tab on the close button moves to the last item. Collapsed sub-menus are skipped. The cart drawer works the same way (js/main.js, section 9b).
  2. Minified files: every minified file now has its original next to it (css/bootstrap.css, js/bootstrap.bundle.js, fonts/font-awesome/all.css, lib/swiper/swiper-bundle.css and swiper-bundle.js). The original AOS source (JavaScript and SCSS) is included in lib/aos/src/ with its license. The Resources section in readme.txt lists them.
  3. Enqueue handles: third-party assets now use their plain names (bootstrap, font-awesome, bootstrap-icons, aos, swiper) in inc/enqueue.php and inc/widgets.php.

Please let me know if anything else needs attention — I'll be glad to fix it right away.

Thank you again for your time and help!

Best regards,
alqamara

#5 @bijayyadav
7 days ago

  • Resolution → live
  • Status reviewing → closed

Setting live.

Thank you

Note: See TracTickets for help on using tickets.