Make WordPress Themes

Opened 5 weeks ago

Last modified 3 hours ago

#293578 approved theme

THEME: Shoping – 1.0.3

Reported by: ashathemes Owned by: luzuk
Priority: previously reviewed Keywords: theme-shoping
Cc: ashathemes21@…

Description

Shoping - 1.0.1

Shoping is a responsive WordPress WooCommerce theme. Fully responsive design displays beautifully across desktop, mobile, and all devices. Easy installation allows you to start posting blogs immediately after activation.

Theme URL - ​https://ashathemes.com/product/shoping-wordpress-woocommerce-theme/
Author URL - ​https://ashathemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/shoping/1.0.1
WordPress.org - ​https://wordpress.org/themes/shoping/

SVN - ​https://themes.svn.wordpress.org/shoping/1.0.1
ZIP - ​https://downloads.wordpress.org/theme/shoping.1.0.1.zip?nostats=1
Live preview – ​https://playground.wordpress.net/#…

Diff with previous version: [351746] https://themes.trac.wordpress.org/changeset?old_path=shoping/1.0.0&new_path=shoping/1.0.1

History:

Ticket Summary Status Resolution Owner
#282662 THEME: Shoping – 1.0.0 closed not-approved bijayyadav
#293578 THEME: Shoping – 1.0.3 approved luzuk

(this ticket)


https://themes.svn.wordpress.org/shoping/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
  • RECOMMENDED: No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
  • RECOMMENDED: No reference to add_theme_support( "responsive-embeds" ) was found in the theme. It is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_theme_support( "align-wide" ) was found in the theme. It is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_theme_support( "wp-block-styles" ) was found in the theme. It is recommended that the theme implement this functionality.
  • RECOMMENDED: Tested up to is recommended to have major versions only (e.g. 5.8). Patch version is not needed (e.g. 5.8.1).

Change History (8)

#1 @ashathemes
5 weeks ago

I fixed all issues

  • Corrected WordPress capitalization in the theme description.
  • Updated "Tested up to" to WordPress 7.1.2.
  • Documented license details and source URLs for images used in the theme screenshot.
  • Documented the license and source URL for the Google font (Roboto) used by the theme.
  • Removed the bundled third-party copy of Masonry; the grid layout is now served without a bundled script.
  • Removed references to third-party libraries that are not included in the theme.
  • Removed the unused, empty custom-style.css file.
  • Prefixed all theme-specific identifiers (customizer settings/controls, script and style handles, menu location, widget area id).
  • Fixed invalid closing markup in the single post template.

#2 @themetracbot
3 weeks ago

  • Summary THEME: Shoping – 1.0.1 → THEME: Shoping – 1.0.2

Shoping - 1.0.2

Shoping is a responsive WordPress WooCommerce theme. Fully responsive design displays beautifully across desktop, mobile, and all devices. Easy installation allows you to start posting blogs immediately after activation.

Theme URL - ​https://ashathemes.com/product/shoping-wordpress-woocommerce-theme/
Author URL - ​https://ashathemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/shoping/1.0.2
WordPress.org - ​https://wordpress.org/themes/shoping/

SVN - ​https://themes.svn.wordpress.org/shoping/1.0.2
ZIP - ​https://downloads.wordpress.org/theme/shoping.1.0.2.zip?nostats=1
Live preview – ​https://playground.wordpress.net/#…

Diff with previous version: [353122] https://themes.trac.wordpress.org/changeset?old_path=shoping/1.0.1&new_path=shoping/1.0.2

History:

Ticket Summary Status Resolution Owner
#282662 THEME: Shoping – 1.0.0 closed not-approved bijayyadav
#293578 THEME: Shoping – 1.0.3 approved luzuk

(this ticket)


https://themes.svn.wordpress.org/shoping/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
  • RECOMMENDED: No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
  • RECOMMENDED: No reference to add_theme_support( "responsive-embeds" ) was found in the theme. It is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_theme_support( "align-wide" ) was found in the theme. It is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_theme_support( "wp-block-styles" ) was found in the theme. It is recommended that the theme implement this functionality.
  • RECOMMENDED: Tested up to is recommended to have major versions only (e.g. 5.8). Patch version is not needed (e.g. 5.8.1).

This ticket was mentioned in ​Slack in #themes by luzuk. ​View the logs.


3 weeks ago

#4 @bijayyadav
3 weeks ago

  • Owner set to luzuk
  • Status new → reviewing

#5 @luzuk
7 days ago

Hello @ashathemes ,
We found some errors on your theme, the list are below, please correct and resubmit the theme.

The skip link points to #content, but single.php does not contain id="content". live.php has hasContent: false.
404.php contains id="blog" — the skip link fails.

Shop page: sorting + result count missing (functional)

do_action( 'woocommerce_before_shop_loop' ) call is not happening in woocommerce/archive-product.php.
Live shop: hasResultCount: false, hasOrdering: false — “Show results” + dropdown both missing.

Product category title hardcoded “Shop”

The heading “Shop” is also visible on the Category URL (/product-category/uncategorized/).
woocommerce_page_title() not used — hardcode esc_html_e( 'Shop' ).

inc/woocommerce.php — unclosed comment (critical code smell)

Docblock close */ missing; That's why this line went into the comment section:
woocommerce.php
Ln 72–72
add_filter( 'woocommerce_enqueue_styles', 'return_empty_array' );

3rd-party asset handles wrongly prefixed

shopping-bootstrap, shopping-font-awesome, shopping-slicknav — handles of framework/libs should not be prefixed (bootstrap, font-awesome, slicknav).

Search query not escaped

printf( esc_html( 'Search Results for: %s', 'shopping' ), '<span>' . get_search_query() . '</span>' );
get_search_query() needs esc_html().

keyboard focus weak

a:hover { outline: none; } + only color change on focus — no clear focus ring (a11y review issue).

Thank you

#6 @themetracbot
8 hours ago

  • Summary THEME: Shoping – 1.0.2 → THEME: Shoping – 1.0.3

Shoping - 1.0.3

Shoping is a responsive WordPress WooCommerce theme. Fully responsive design displays beautifully across desktop, mobile, and all devices. Easy installation allows you to start posting blogs immediately after activation.

Theme URL - ​https://ashathemes.com/product/shoping-wordpress-woocommerce-theme/
Author URL - ​https://ashathemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/shoping/1.0.3
WordPress.org - ​https://wordpress.org/themes/shoping/

SVN - ​https://themes.svn.wordpress.org/shoping/1.0.3
ZIP - ​https://downloads.wordpress.org/theme/shoping.1.0.3.zip?nostats=1
Live preview – ​https://playground.wordpress.net/#…

Diff with previous version: [356797] https://themes.trac.wordpress.org/changeset?old_path=shoping/1.0.2&new_path=shoping/1.0.3

History:

Ticket Summary Status Resolution Owner
#282662 THEME: Shoping – 1.0.0 closed not-approved bijayyadav
#293578 THEME: Shoping – 1.0.3 approved luzuk

(this ticket)


https://themes.svn.wordpress.org/shoping/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
  • RECOMMENDED: No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
  • RECOMMENDED: No reference to add_theme_support( "responsive-embeds" ) was found in the theme. It is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_theme_support( "align-wide" ) was found in the theme. It is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_theme_support( "wp-block-styles" ) was found in the theme. It is recommended that the theme implement this functionality.

#7 @ashathemes
8 hours ago

I fixed all issues.

  • Fixed skip link target id in single.php and 404.php.
  • Added woocommerce_before_shop_loop action in woocommerce/archive-product.php for result count and ordering dropdown.
  • Replaced hardcoded Shop heading with woocommerce_page_title() for product category and archive pages.
  • Fixed unclosed docblock comment in inc/woocommerce.php.
  • Corrected 3rd-party asset handles (bootstrap, font-awesome, slicknav) to avoid theme prefix.
  • Added esc_html() escaping for get_search_query() in search.php.
  • Enhanced keyboard focus visibility with distinct focus indicators across interactive elements.

#8 @luzuk
3 hours ago

  • Status reviewing → approved

Hello @ashathemes ,

Thanks to solve the given issues,now theme is good for us, we are going to
approve this theme then it will automatically move to approve queue.
Best of Luck...!

Note: See TracTickets for help on using tickets.