THEME: Kamishiro – 0.7.4

[concretus]

Kamishiro - 0.7.0

A lightweight block theme for readable Japanese long-form content and detailed B2B product information.

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/kamishiro/0.7.0
WordPress.org - ​https://wordpress.org/themes/kamishiro/

SVN - ​https://themes.svn.wordpress.org/kamishiro/0.7.0
ZIP - ​https://downloads.wordpress.org/theme/kamishiro.0.7.0.zip?nostats=1
Live preview – ​https://playground.wordpress.net/#…

Diff with previous version: [351747] https://themes.trac.wordpress.org/changeset?old_path=kamishiro/0.3.3&new_path=kamishiro/0.7.0

History:

Ticket	Summary	Status	Resolution	Owner
#282666	THEME: Kamishiro – 0.3.3	closed	not-approved	bijayyadav
#293579	THEME: Kamishiro – 0.7.4	closed	live	bikram_sth
(this ticket)

[concretus]

This is the updated submission following review ticket #282666. The three issues raised there (English readme, internationalized user-facing PHP strings, and long-title overflow) have been addressed in this version.

The detailed response and validation summary are at https://themes.trac.wordpress.org/ticket/282666#comment:5

Thank you for reviewing the updated theme.

[bikram_sth]

I want to review this theme, please assign to me

[bikram_sth]

Hi @concretus ,

Please fix the following issues,

Google site search — external third-party service / non-presentational functionality

The theme rewrites the core Search block's form to submit visitor queries to an external service (Google), which is a remote resource dependency and non-presentational functionality:

• inc/google-search.php:52 — sets form action to ​https://www.google.com/search (filter render_block_core/search)
• inc/google-search.php:72 — injects a hidden as_sitesearch field
• patterns/google-site-search.php:13 — Search block with class is-style-kamishiro-google-search
• styles/google-site-search.json — block style variation for core/search
• assets/css/typography.css:49 — styles .is-style-kamishiro-google-search
• readme.txt — dedicated "Google Site Search" section documents the behaviour

Conflicts with the forbidden Theme Check pattern "Google search or advertising code", the remote-resource / no-remote-dependencies rule, and the "functionality that is not related to design and presentation" / plugin-territory rule. A reviewer is likely to require this be removed and core search used.

readme.txt missing the Contributors header

The readme header block (readme.txt:1-8) has no Contributors: line with a single WordPress.org username. The standard readme structure expects it. Changelog 0.3.3 (readme.txt:92) even states the Contributors field was intentionally removed.

Privacy documentation missing

readme.txt has no == Privacy == section (readme.txt:12 onward). How user data is collected and used is expected to be documented in readme.txt. The Google search passes the visitor's query string to a third party, and no privacy documentation exists anywhere. Required item.

Screenshot does not match the theme as loaded

The screenshot shows a corporate homepage (changelog 0.3.0, readme.txt:107), but on activation the theme renders a plain blog list — templates/index.html (and templates/home.html), headed "新着記事" with a query loop. Nothing applies the corporate layout, and the readme itself states the homepage is not changed automatically and the corporate pattern (kamishiro/corporate-home-starter) must be inserted and set as the homepage manually (readme.txt:30, readme.txt:36). A screenshot must be an actual front-end capture that reflects the theme's real, default appearance, so depicting a state the theme does not load by default can be flagged (it also fails "default settings shown").

Secondary point: screenshot.png is absent from the readme "Resources" list (readme.txt:45-61), which documents only the four assets/images/*.webp files, so its source/license and any AI/composite provenance are undisclosed.

Thank you!

[themetracbot]

Kamishiro - 0.7.3

A lightweight block theme for readable Japanese long-form content and detailed B2B product information.

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/kamishiro/0.7.3
WordPress.org - ​https://wordpress.org/themes/kamishiro/

SVN - ​https://themes.svn.wordpress.org/kamishiro/0.7.3
ZIP - ​https://downloads.wordpress.org/theme/kamishiro.0.7.3.zip?nostats=1
Live preview – ​https://playground.wordpress.net/#…

Diff with previous version: [354284] https://themes.trac.wordpress.org/changeset?old_path=kamishiro/0.7.0&new_path=kamishiro/0.7.3

History:

Ticket	Summary	Status	Resolution	Owner
#282666	THEME: Kamishiro – 0.3.3	closed	not-approved	bijayyadav
#293579	THEME: Kamishiro – 0.7.4	closed	live	bikram_sth
(this ticket)

[bikram_sth]

Hi @concretus ,

Checked latest updated theme but still there are issuses that need to be fixed

Untranslatable Hardcoded Strings in Block Template/Part HTML (Breaks "translation-ready" Tag)

• Issue: Block template and part HTML files contain hardcoded visible Japanese strings. Core does not automatically translate text inside templates/*.html or parts/*.html block markup. For a theme tagged "translation-ready", all visible front-end text must be internationalized.
• Locations:

templates/404.html — "ページが見つかりません", "サイト内検索", "キーワードを入力"
templates/archive.html — "続きを読む", empty-state messages, pagination ("前のページ"/"次のページ")
templates/home.html — "続きを読む", empty-state messages, pagination ("前のページ"/"次のページ")
templates/index.html — "新着記事", "続きを読む", empty-state messages, pagination ("前のページ"/"次のページ")
templates/search.html — "キーワードを入力", "続きを読む", empty-state messages, pagination ("前のページ"/"次のページ")
templates/single.html — "タグ: ", post navigation ("前の記事"/"次の記事")
parts/comments.html — "コメント"
parts/footer.html — "日本語を、軽く、美しく。"

• Evidence: Grep matches show these strings in template/part HTML; languages/kamishiro.pot includes only "新着記事" and "続きを読む" (mostly from pattern contexts), not the full set of template/part visible strings.

[themetracbot]

Kamishiro - 0.7.4

A lightweight block theme for readable Japanese long-form content and detailed B2B product information.

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/kamishiro/0.7.4
WordPress.org - ​https://wordpress.org/themes/kamishiro/

SVN - ​https://themes.svn.wordpress.org/kamishiro/0.7.4
ZIP - ​https://downloads.wordpress.org/theme/kamishiro.0.7.4.zip?nostats=1
Live preview – ​https://playground.wordpress.net/#…

Diff with previous version: [354347] https://themes.trac.wordpress.org/changeset?old_path=kamishiro/0.7.3&new_path=kamishiro/0.7.4

History:

Ticket	Summary	Status	Resolution	Owner
#282666	THEME: Kamishiro – 0.3.3	closed	not-approved	bijayyadav
#293579	THEME: Kamishiro – 0.7.4	closed	live	bikram_sth
(this ticket)

[bikram_sth]

Hi @concretus ,

Thank you for the update. The theme has been approved and is ready for final review.

• The ticket will now be moved to the admin queue for review before being made live.

Thank you

[bijayyadav]

Hi @concretus

I am setting this theme live. Please fix the following issues in the next update

• Please add all user-facing text strings in the PHP files in English and make them internationalized and wrapped in the appropriate translation functions to make the theme translation-ready.

Thank you.